Conversation
There was a problem hiding this comment.
1 issue found across 34 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Makefile">
<violation number="1" location="Makefile:234">
P2: `ifndef CLANG_FORMAT` is ineffective here because `CLANG_FORMAT` is always defined (possibly empty). This bypasses the intended missing-tool check.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This introduces 'make indent' target that runs clang-format-20, shfmt, and black across the codebase. The shfmt flags (-i 4 -fn -ci -sr -bn) honor .editorconfig settings. Change-Id: I008a57d2d335a5c866dffa10d3a1d9953906d7fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces 'make indent' target that runs clang-format-20, shfmt, and black across the codebase. The shfmt flags (-i 4 -fn -ci -sr -bn) honor .editorconfig settings.
Change-Id: I008a57d2d335a5c866dffa10d3a1d9953906d7fe
Summary by cubic
Adds
make indentto auto-format C, shell, and Python withclang-format-20,shfmt, andblack. Reformats the codebase for consistent style; no behavior changes.make indentrunsclang-format-20(version 20 required),shfmt(-i 4 -fn -ci -sr -bn), andblackover project sources..editorconfigto align shell formatting withshfmt.clang-formatversion and locates tools before formatting.Written for commit d17545c. Summary will update on new commits.