Skip to content

Add make indent and enforce consistent code style - #7

Merged
jserv merged 1 commit into
mainfrom
indent
Mar 21, 2026
Merged

Add make indent and enforce consistent code style#7
jserv merged 1 commit into
mainfrom
indent

Conversation

@jserv

@jserv jserv commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

This introduces 'make indent' target that runs clang-format-20, shfmt, and black across the codebase. The shfmt flags (-i 4 -fn -ci -sr -bn) honor .editorconfig settings.

Change-Id: I008a57d2d335a5c866dffa10d3a1d9953906d7fe


Summary by cubic

Adds make indent to auto-format C, shell, and Python with clang-format-20, shfmt, and black. Reformats the codebase for consistent style; no behavior changes.

  • New Features
    • make indent runs clang-format-20 (version 20 required), shfmt (-i 4 -fn -ci -sr -bn), and black over project sources.
    • Adds .editorconfig to align shell formatting with shfmt.
    • Makefile validates clang-format version and locates tools before formatting.

Written for commit d17545c. Summary will update on new commits.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 34 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Makefile">

<violation number="1" location="Makefile:234">
P2: `ifndef CLANG_FORMAT` is ineffective here because `CLANG_FORMAT` is always defined (possibly empty). This bypasses the intended missing-tool check.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread Makefile Outdated
This introduces 'make indent' target that runs clang-format-20, shfmt,
and black across the codebase. The shfmt flags (-i 4 -fn -ci -sr -bn)
honor .editorconfig settings.

Change-Id: I008a57d2d335a5c866dffa10d3a1d9953906d7fe
@jserv
jserv merged commit 677806c into main Mar 21, 2026
3 checks passed
@jserv
jserv deleted the indent branch March 21, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant