Replace strncpy() with strscpy helpers - #94
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
It has been discouraged in linux kernel to use strncpy() as it had been a persistent source of bugs due to its ambiguous intent and counter-intuitive semantics. And because of that, it was removed from linux kernel 7.2. Replace strncpy() with strscpy() for null termination and strscpy_pad() for null terminations with padding which provides more safer string copying semantics and guarantees null termination when destination buffer is non-empty.
EricKim27
changed the title
Collaborator
|
Thank @EricKim27 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been discouraged in linux kernel to use strncpy() as it had been a persistent source of
bugs due to its ambiguous intent and counter-intuitive semantics.
And because of that, it was removed from linux kernel 7.2.
Replace strncpy() with strscpy() which provides more safer string copying semantics
and guarantees null termination when destination buffer is non-empty.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=079a028d6327e68cfa5d38b36123637b321c19a7
Summary by cubic
Replace
strncpy()withstrscpy()andstrscpy_pad()ininode.candsuper.cfor safer string copying with guaranteed null-termination and proper padding. This prevents silent truncation and keeps the filesystem compatible with kernels that removedstrncpy().strscpy_pad()for directory filenames and rename paths to fill fixed-size fields.strscpy()for symlinki_dataand when writing inodei_datato disk.Written for commit 24a219e. Summary will update on new commits.