Login sync bc#174
Merged
Merged
Conversation
erinxocon
approved these changes
Oct 21, 2025
zephyranthes03
added a commit
that referenced
this pull request
Oct 30, 2025
This reverts commit 0970060.
zephyranthes03
added a commit
that referenced
this pull request
Oct 31, 2025
* Add rate limiting and security to OAuth endpoints - Add rate limiting to all OAuth endpoints to prevent abuse - Token endpoint: 100/min per IP+client_id (independent quotas per OAuth client) - Authorize endpoint: 50/min per IP - User OAuth (GitHub/Google): 20/min per IP - Invalid paths: 10/min per IP - Add catch-all route for scanning attacks (/oauth/.env, etc.) - Support X-Forwarded-For for load balancers Fixes Datadog errors from endpoint scanning attacks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Revert "Login sync bc (#174)" This reverts commit 0970060. * Revert "Update Oauth account can't recevice password changing email (#173)" This reverts commit 3b7cd90. * Revert "Redirect 405 error (#172)" This reverts commit b16b416. * Revert "Fix BigCommerce integration to prevent incomplete account creation (#171)" This reverts commit d37bde6. * Revert "Update email login cases - only 422 email exist case can success now (#170)" This reverts commit f836a1e. * Revert "Fix deploy issue (#169)" This reverts commit 1c25838. * Revert "Add rate limiting and security to OAuth endpoints" This reverts commit 0a65c21. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What we happen
When BigCommerce (BC) customer sync failed, our side treated it as a hard failure. That meant the login flow could get interrupted even though the problem was on the BC side-inefficient and brittle.
What I changed
Post-login customer sync: Added a sync step that runs during/after login. Even if the initial sync fails, subsequent logins will automatically retry the account sync so users can continue.
Stricter logging: Raised the log level for related warnings so we can better monitor recurring patterns and catch regressions faster.
Impact
BC-side sync can fix when user login process.
We’ll keep an eye on the elevated warnings to validate that retries are working as expected and to spot any edge cases.