This repository was archived by the owner on Feb 6, 2026. It is now read-only.
fix(buck2): declare build_deps on docker_image as dep type#2619
Merged
si-bors-ng[bot] merged 1 commit intomainfrom Aug 16, 2023
Merged
fix(buck2): declare build_deps on docker_image as dep type#2619si-bors-ng[bot] merged 1 commit intomainfrom
build_deps on docker_image as dep type#2619si-bors-ng[bot] merged 1 commit intomainfrom
Conversation
This change fixes an issue when our CI/CD system computes "work to do" in the `si/merge-queue` pipeline. Prior to this change the `build_deps` attribute on the `docker_image` Buck2 rule was type `string`, primarily as these values were being passed further down for more processing via a BXL and Python script. The issue arises when we compute dependent work on source file changes, say `bin/council/src/main.rs` which should be pulled into `//bin/council:image` via the `//bin/council:council` target. As our attribute type here was `string`, Buck2 doesn't know we want to consider this as an input to the image. In this case we don't need the inputs *built*, only declared so that later when we ask the question "what are all reverse deps that are impacted with this source change", we get our Docker image builds as one of the targets. Changing the attribute type to `dep` allows Buck2 to track this in its graph. Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
Contributor
Author
|
bors try |
Contributor
tryBuild succeeded: |
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an issue when our CI/CD system computes "work to do" in the
si/merge-queuepipeline. Prior to this change thebuild_depsattribute on thedocker_imageBuck2 rule was typestring, primarily as these values were being passed further down for more processing via a BXL and Python script.The issue arises when we compute dependent work on source file changes, say
bin/council/src/main.rswhich should be pulled into//bin/council:imagevia the//bin/council:counciltarget. As our attribute type here wasstring, Buck2 doesn't know we want to consider this as an input to the image. In this case we don't need the inputs built, only declared so that later when we ask the question "what are all reverse deps that are impacted with this source change", we get our Docker image builds as one of the targets. Changing the attribute type todepallows Buck2 to track this in its graph.