This repository was archived by the owner on Feb 6, 2026. It is now read-only.
feat(si-layer-cache): impl rebaser requests work queue stream#3470
Merged
si-bors-ng[bot] merged 1 commit intomainfrom Mar 25, 2024
Merged
feat(si-layer-cache): impl rebaser requests work queue stream#3470si-bors-ng[bot] merged 1 commit intomainfrom
si-bors-ng[bot] merged 1 commit intomainfrom
Conversation
This is an initial implementation of a work queue stream of rebaser requests, suitable for use by the rebaser service. Note that it's not yet clear if additional work queue streams follow this pattern, if the code is extractable into the service-related crates, or if some other code de-duplication is possible. At the moment, the newly added Rust types are doing a *lot* of heavy lifting to ensure correctness of behavior and type safety. Also note that this NATS Jetstream setup may require further testing and refinement to confirm the desired stream sourcing behavior. Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
Contributor
Author
|
bors try |
Contributor
tryBuild succeeded: |
Contributor
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of a work queue stream of rebaser requests, suitable for use by the rebaser service.
Note that it's not yet clear if additional work queue streams follow this pattern, if the code is extractable into the service-related crates, or if some other code de-duplication is possible. At the moment, the newly added Rust types are doing a lot of heavy lifting to ensure correctness of behavior and type safety.
Also note that this NATS Jetstream setup may require further testing and refinement to confirm the desired stream sourcing behavior.