This repository was archived by the owner on Feb 6, 2026. It is now read-only.
build: alter Docker image multi-arch promotion for certain images#5259
Merged
build: alter Docker image multi-arch promotion for certain images#5259
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
fnichol
force-pushed
the
sf/prune-noncritical-merge-builds
branch
from
d40c514 to
50cf092
Compare
sprutton1
approved these changes
Jan 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This change changes the default machine architectures that are expected to have Docker images being built and published to Docker Hub for tag promotion (in the `si/merge-main` CI pipeline). By default, it's expected that an ARM and an X86-64 image will be produced. In this change it's now possible to change that default assumption and to only specify the machine architectures expected to have been published. The underlying Python script and corresponding `docker_image_promote` rule already had this capability but the `docker_image` Buck2 macro wasn't able to handle this prior to this change. This change works in concert with changes to `si-ci` which will filter out non-critical artifact builds in the `si/merge-queue` pipeline. Signed-off-by: Fletcher Nichol <fletcher@systeminit.com>
fnichol
force-pushed
the
sf/prune-noncritical-merge-builds
branch
from
50cf092 to
fd732c9
Compare
sprutton1
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change changes the default machine architectures that are expected to have Docker images being built and published to Docker Hub for tag promotion (in the
si/merge-mainCI pipeline).By default, it's expected that an ARM and an X86-64 image will be produced. In this change it's now possible to change that default assumption and to only specify the machine architectures expected to have been published. The underlying Python script and corresponding
docker_image_promoterule already had this capability but thedocker_imageBuck2 macro wasn't able to handle this prior to this change.This change works in concert with changes to
si-ciwhich will filter out non-critical artifact builds in thesi/merge-queuepipeline.