This repository was archived by the owner on Oct 9, 2020. It is now read-only.
Upgrade Rollup to ^0.58.2 #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great work, thanks so much for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Rollup to ^0.58.2 in order to fix jspm/jspm#2405:
moduleNamehas been renamed toname, not mentioned in the changelog but it complains otherwise (andmoduleNameisn't in https://rollupjs.org/guide/en#big-list-of-options)bundle.generatenow returns a Promise as per https://github.com/rollup/rollup/blob/master/CHANGELOG.md#0450es6module format has been renamedes(deprecated in https://github.com/rollup/rollup/blob/master/CHANGELOG.md#0320)formatdoesn't default toesanymore (see [WIP] Better warnings etc rollup/rollup#1491 (comment))npm testruns without errors & I've successfully testedjspm buildwith different output formats in some small projects. This might break existing code relying on Rollup previous buggy behaviors that have now been fixed.