build(deps): bump x25519-dalek 2.0 -> 3.0 across the workspace#244
Merged
Conversation
Combined bump superseding Dependabot PRs #232/#233/#235, which each bumped one crate's manifest and could not compile alone (same lockstep issue as the aes-gcm 0.11 bump in #227). Code changes required by 3.0 (curve25519-dalek 5.0, rand_core 0.10): - StaticSecret/EphemeralSecret::random_from_rng(OsRng) no longer accepts rand_core 0.6's OsRng; switch call sites to ::random() (new 'getrandom' feature), which keeps the same panic-on-RNG-failure semantics and uses the getrandom 0.4 dep both crates already carry (wasm_js backend already configured for wasm builds). - Drop now-unused rand_core::OsRng imports. - Update crypto_core/fuzz/Cargo.lock for the cargo-fuzz CI jobs. Drive-by cleanups in touched builds: - wasm.rs encode_data: mark the ignored block_size parameter as unused and document that this path emits a single packet (no fountain coding) instead of implying the value takes effect. - rust_crypto python-gated AES-GCM paths: replace deprecated Nonce::from_slice with Nonce::try_from (missed by #227 because this code only compiles under the 'python' feature). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…19-dalek 3.0 branch
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined bump superseding the three single-crate Dependabot PRs #232, #233, #235, which cannot compile individually (same workspace-lockstep issue as the aes-gcm 0.11 bump, #227).
Code changes required by 3.0 (curve25519-dalek 5.0, rand_core 0.10)
random_from_rng(OsRng)no longer accepts rand_core 0.6'sOsRng→ switched call sites to the new::random()(via thegetrandomcrate feature), which keeps the same panic-on-RNG-failure semantics and resolves to the getrandom 0.4 dependency both crates already carry (wasm_js backend already configured).rand_core::OsRngimports.crypto_core/fuzz/Cargo.lockso the cargo-fuzz CI jobs pick up 3.0.Drive-by cleanups in touched builds
wasm.rs encode_data: theblock_sizeparameter was silently ignored — now marked unused and documented (this path emits a single packet; no fountain coding).Nonce::from_slicewithNonce::try_from(missed by build(deps): bump aes-gcm 0.10 → 0.11 across all crates + API migration #227 because these sites only compile under thepythonfeature).Verification
cargo clippy --workspace --all-targets -- -D warningscleancargo test -p crypto_coreandcargo test -p meow_crypto_rsall green (incl. the Fable bug-hunt PoC tests covering X25519 low-order rejection and zeroization)pq,python,pq, andwasmfeature combinations compileCloses #232, closes #233, closes #235.
🤖 Generated with Claude Code