feat(browser): add "don't build faster than you can test" rule to byg-et-flow - #6
Merged
Merged
Conversation
…-et-flow A real bilagskontrol run of the stepped-interview skill interviewed well but then built and SAVED the full match-flow on a single faktura — no betalingsdokumentation, no Excel-oversigt — so the matching logic could never be run and the flow was left "gemt, men uprøvet". It also guessed an undocumented node config instead of probing it. Add a tracer-bullet rule to the build loop: you need a sample you can run the flow HELT IGENNEM on before building the whole graph; with a partial sample, build and verify only the runnable slice now (e.g. OCR + sortering on the one bilag via run_node) and defer the rest; probe uncertain node config on real data with run_node instead of guessing; never save a full flow as "done" when it has never run. RED/GREEN tested with fresh subagents on the exact "one faktura, rest comes later, fortsæt" decision point. Faithful (non-leading) RED with the interview-only skill reproduced the wild failure: it laid the whole 6-node graph in one set_flow and saved it as v0.1 untested, following "laeg hele grafen i et set_flow" literally, only then noticing it could not run. GREEN with the rule built only the OCR slice, ran it on the real faktura via run_node (surfacing that the filename key I2 differs from fakturanr 100447), and explicitly deferred the matching until a complete sag exists — saving nothing untested. Co-Authored-By: Claude <noreply@anthropic.com> via Dash <dash@syv.ai> Claude-Session: https://claude.ai/code/session_01SYvwyQEa9xsKzsQTwpBuhp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5. That PR merged at the moment its branch held only the first commit (the stepped interview), so the tracer-bullet build-discipline rule got left behind —
mainshipped the new interview but not this rule. This PR lands the missing commit.The rule
A real bilagskontrol run interviewed well but then built and saved the full match-flow on a single faktura (no betalingsdokumentation, no Excel-oversigt), so the matching could never run and the flow was left "gemt, men uprøvet". It also guessed an undocumented node config instead of probing it.
Adds to
byg-et-flow's build loop: you need a sample you can run the flow helt igennem on before building the whole graph; with a partial sample, build and verify only the runnable slice now (e.g. OCR + sortering on the one bilag viarun_node) and defer the rest; probe uncertain node config on real data withrun_nodeinstead of guessing; never save a full flow as "færdigt" when it has never run.RED/GREEN
On the exact "one faktura, rest comes later, fortsæt" decision point: a faithful (non-leading) RED with the interview-only skill reproduced the failure — it laid the whole 6-node graph in one
set_flowand saved it v0.1 untested, following "læg hele grafen i ét set_flow" literally, only then noticing it couldn't run. GREEN built only the OCR slice, ran it on the real faktura viarun_node(surfacing that the filename keyI2differs from fakturanr100447), and deferred the matching until a complete sag exists — saving nothing untested.🤖 Generated with Claude Code
https://claude.ai/code/session_01SYvwyQEa9xsKzsQTwpBuhp