[BUGFIX] News extension list view: update no-image-markup#380
Merged
aennafae merged 1 commit intot3kit:masterfrom Jan 15, 2018
Merged
[BUGFIX] News extension list view: update no-image-markup#380aennafae merged 1 commit intot3kit:masterfrom
aennafae merged 1 commit intot3kit:masterfrom
Conversation
In the list view of the news extension the markup for the fallback image is updated. It uses an image-tag instead of a css-background-image now. This works better for setting an image size. An aria-role was added to markup the image as presentational.
dmh
added a commit
that referenced
this pull request
Feb 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the list view of the news extension the markup for the fallback image is updated.
It uses an image-tag instead of a css-background-image now.
This works better for setting an image size.
An aria-role was added to markup the image as presentational.