Skip to content

Conversation

@nikhillakshman
Copy link
Contributor

Release Extensions 1.4.0

johnDance
johnDance previously approved these changes May 11, 2020
Copy link
Contributor

@johnDance johnDance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

seanmakesgames
seanmakesgames previously approved these changes May 11, 2020
@ashwinar
Copy link
Contributor

We should also check-in the package-lock.json file that gets updated when you update types.

Copy link
Contributor

@ashwinar ashwinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check-in the package-lock.json file that gets updated when you update types.

@nikhillakshman nikhillakshman dismissed stale reviews from seanmakesgames and johnDance via 998d3dd May 12, 2020 19:06
@nikhillakshman nikhillakshman requested a review from ashwinar May 12, 2020 20:07
@nikhillakshman nikhillakshman merged commit ce28548 into master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants