Plan-dumper: Add Umbra, CedarDB and MariaDB - #164
Merged
Conversation
I am planning to add support for additional database engines. In preparation for that, this commit adds plan dumps for Umbra, CedarDB, MariaDB, and Trino. To do so, the plan-dumper is extended to support those new databsaes.
vogelsgesang
commented
Aug 24, 2026
Preserve fixtures that the active engine build cannot regenerate, collect stable MariaDB statistics, and filter engine-specific memory, scheduler, and identifier fields alongside timing measurements.
Document engine-specific limitations, align all server connections behind explicit CLI arguments, and shorten the recursive CTE so Trino can produce an analyzed fixture.
Generate each engine into an empty staging directory so stale outputs cannot survive a run, and fail atomically when a requested mode is unavailable. Keep the sole legacy fixture as an explicit manual input and drop the obsolete TDE example.
Drop the obsolete camel-case Hyper example and keep every staged engine folder derived solely from its requested SQL plans. Remove the unused mode mapping hook left behind by Trino's former analyze fallback.
vogelsgesang
commented
Aug 24, 2026
Describe the hunk-level behavior directly and list each engine's volatile runtime fields in a scan-friendly format.
vogelsgesang
commented
Aug 24, 2026
Import the declared dependencies directly so incomplete installations fail immediately instead of silently skipping configured databases.
Use uppercase snake case for module-level constants and regular expressions so the dumper follows standard Python naming conventions throughout.
Keep dialect differences in dedicated SQL files so the dumper executes setup statements verbatim instead of parsing and rewriting their DDL.
Keep schema, imports, and statistics in one selected setup script per engine, with lightweight include and client-copy directives for shared setup concerns.
Implement the setup \copy directive with PostgreSQL's client-side COPY protocol instead of materializing rows and issuing batched inserts.
vogelsgesang
force-pushed
the
plan-dumper-more-dbs
branch
2 times, most recently
from
August 25, 2026 08:51
8924a42 to
69a68b7
Compare
vogelsgesang
changed the title
vogelsgesang
force-pushed
the
plan-dumper-more-dbs
branch
from
August 25, 2026 08:52
69a68b7 to
162084c
Compare
vogelsgesang
force-pushed
the
plan-dumper-more-dbs
branch
from
August 25, 2026 08:58
162084c to
49af6c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am planning to add support for additional database engines. In preparation for that, add reproducible query-plan fixtures for Umbra, CedarDB, and MariaDB.
\includeand\copysetup directives where native SQL loading is insufficient.