Skip to content

fix: CSVImport bugs (AUTH column, case-insensitive validation, username case) + QuerysetEndpoint.find_by_name#1811

Open
jacalata wants to merge 8 commits into
developmentfrom
jac/csv-import-fixes-and-find-by-name
Open

fix: CSVImport bugs (AUTH column, case-insensitive validation, username case) + QuerysetEndpoint.find_by_name#1811
jacalata wants to merge 8 commits into
developmentfrom
jac/csv-import-fixes-and-find-by-name

Conversation

@jacalata

@jacalata jacalata commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

CSVImport fixes

Bug 1 — AUTH column unreachable (off-by-one on MAX)
ColumnType.AUTH = 7 and ColumnType.MAX = 7 were equal, so any 8-column line was rejected as "too many columns". MAX is now 8 (number of columns, not last index).

Bug 2 — create_user_from_line lowercased the whole line including usernames
line.strip().lower() ran before splitting, destroying case for LDAP/mixed-case usernames. Now only the comparison-relevant fields (license, admin, publisher, auth) are normalized.

Bug 3 — TableauIDWithMFA missing from validation allowlist
_valid_attributes for the auth column omitted TableauIDWithMFA, causing valid CSVs to be rejected.

Bug 4 — Case-sensitive validation rejected valid mixed-case values
_validate_attribute_value compared raw input against lowercase allowlists, so Viewer, Creator, SAML etc. were all rejected. Validation now normalizes each field's value to lowercase (or canonical form for auth) before comparison.

find_by_name

def find_by_name(self, name: str) -> list[T]:
    return list(self.filter(name=name))

Added to QuerysetEndpoint. Available on workbooks, datasources, views, users, projects, groups. Returns a list — empty if nothing matches, multiple items if names collide across projects.

Tests

5 new tests in test_user_model.py:

  • test_validate_mixed_case_licenseViewer/Creator/EXPLORER all pass
  • test_validate_tableauid_with_mfa_authTableauIDWithMFA accepted
  • test_create_user_preserves_username_caseJSmith stays JSmith
  • test_create_user_with_auth_column — 8-column line parsed correctly
  • test_too_many_columns_raises — 9-column line raises

Full suite: 848 passed, 1 skipped.

Notes

The pre-commit hook fails on this repo with black 22.x due to py312/py313 in pyproject.toml target-version. Files were formatted manually with --target-version py311 and committed with --no-verify. This is a pre-existing repo setup issue.

Closes #1809
Closes #1810

🤖 Generated with Claude Code

jacalata and others added 8 commits July 6, 2026 12:30
Add Read the Docs configuration file for documentation build
Added configuration settings for Sphinx documentation. Direct copy from example conf file.
Updated project information to load from pyproject.toml.
- Add docs optional-dependencies group (sphinx, tomli) to pyproject.toml
- Wire up .readthedocs.yaml to install .[docs] extra
- Fix conf.py: correct pyproject.toml path, use importlib.metadata for
  version, switch to alabaster theme, use tomllib/tomli compat import
- Add minimal docs/index.rst
- Fix RST docstring errors in connection_item, site_item, job_item,
  task_item that caused Sphinx build warnings/errors

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
On push to master, builds Sphinx HTML and opens a PR from
docs-update into gh-pages so the generated API reference
can be reviewed before going live.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…servation; add find_by_name

Fixes for UserItem.CSVImport (issue #1809):
- MAX=8 (was 7=AUTH index): 8-column lines with auth type no longer
  rejected as "too many columns"
- create_user_from_line no longer lowercases the whole line before
  splitting — username case is preserved
- _validate_import_line_or_throw normalizes license/admin/publisher to
  lowercase and auth to canonical form before comparison, so 'Viewer',
  'Creator', 'SAML', 'tableauidwithmfa' etc. are all accepted
- Add TableauIDWithMFA to valid auth values in validation (was missing)
- 5 new tests covering each fix

Add QuerysetEndpoint.find_by_name(name) (issue #1810):
- Thin wrapper over .filter(name=name) returning a list
- Available on all content-item endpoints (workbooks, datasources,
  views, users, projects, groups)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
tableauserverclient
   __init__.py50100% 
   config.py150100% 
   datetime_helpers.py2511 96%
   exponential_backoff.py200100% 
   filesys_helpers.py310100% 
   namespace.py2633 88%
tableauserverclient/bin
   __init__.py20100% 
   _version.py358212212 41%
tableauserverclient/helpers
   __init__.py10100% 
   logging.py20100% 
   strings.py3111 97%
tableauserverclient/models
   __init__.py460100% 
   collection_item.py4177 83%
   column_item.py553232 42%
   connection_credentials.py351111 69%
   connection_item.py941414 85%
   custom_view_item.py1442121 85%
   data_acceleration_report_item.py5411 98%
   data_alert_item.py15844 97%
   data_freshness_policy_item.py1551515 90%
   database_item.py2073636 83%
   datasource_item.py3001212 96%
   dqw_item.py10455 95%
   exceptions.py40100% 
   extensions_item.py13244 97%
   extract_item.py4444 91%
   favorites_item.py6988 88%
   fileupload_item.py190100% 
   flow_item.py1491010 93%
   flow_run_item.py710100% 
   group_item.py8966 93%
   groupset_item.py4977 86%
   interval_item.py1823232 82%
   job_item.py1871010 95%
   linked_tasks_item.py7911 99%
   location_item.py2922 93%
   metric_item.py1291313 90%
   oidc_item.py6333 95%
   pagination_item.py3411 97%
   permissions_item.py1111212 89%
   project_item.py2073131 85%
   property_decorators.py1001818 82%
   reference_item.py2622 92%
   revision_item.py5911 98%
   schedule_item.py20966 97%
   server_info_item.py3777 81%
   site_item.py6361313 98%
   subscription_item.py10122 98%
   table_item.py1191818 85%
   tableau_auth.py612525 59%
   tableau_types.py2711 96%
   tag_item.py150100% 
   target.py60100% 
   task_item.py5622 96%
   user_item.py3211717 95%
   view_item.py2201616 93%
   virtual_connection_item.py6488 88%
   webhook_item.py6911 99%
   workbook_item.py3621616 96%
tableauserverclient/server
   __init__.py90100% 
   exceptions.py40100% 
   filter.py2111 95%
   pager.py3311 97%
   query.py1431515 90%
   request_factory.py1335195195 85%
   request_options.py38655 99%
   server.py1882323 88%
   sort.py60100% 
tableauserverclient/server/endpoint
   __init__.py350100% 
   auth_endpoint.py771111 86%
   custom_views_endpoint.py1521212 92%
   data_acceleration_report_endpoint.py210100% 
   data_alert_endpoint.py942323 76%
   databases_endpoint.py1113030 73%
   datasources_endpoint.py3403535 90%
   default_permissions_endpoint.py4433 93%
   dqw_endpoint.py451616 64%
   endpoint.py1891919 90%
   exceptions.py7766 92%
   extensions_endpoint.py310100% 
   favorites_endpoint.py942222 77%
   fileuploads_endpoint.py510100% 
   flow_runs_endpoint.py6299 85%
   flow_task_endpoint.py2122 90%
   flows_endpoint.py2165555 75%
   groups_endpoint.py12699 93%
   groupsets_endpoint.py7277 90%
   jobs_endpoint.py6799 87%
   linked_tasks_endpoint.py370100% 
   metadata_endpoint.py881414 84%
   metrics_endpoint.py5566 89%
   oidc_endpoint.py4211 98%
   permissions_endpoint.py4433 93%
   projects_endpoint.py1572424 85%
   resource_tagger.py1273535 72%
   schedules_endpoint.py1191111 91%
   server_info_endpoint.py361010 72%
   sites_endpoint.py1302727 79%
   subscriptions_endpoint.py561414 75%
   tables_endpoint.py1103636 67%
   tasks_endpoint.py6366 90%
   users_endpoint.py18388 96%
   views_endpoint.py15099 94%
   virtual_connections_endpoint.py1131010 91%
   webhooks_endpoint.py5499 83%
   workbooks_endpoint.py3542424 93%
TOTAL12012142788% 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add find_by_name() to QuerysetEndpoint for content item lookup UserItem.CSVImport: several bugs prevent reliable use and block tabcmd delegation

1 participant