fix(xerrors): do not silently drop foreign collected errors in Collector.Collect

[Kybxd]

Problem

xerrors.Collector.Collect short-circuited on any *collected error:

var ce *collected
if errors.As(err, &ce) {
    // record outerWM, return; no append to errs, no counter bump
    return nil
}

This branch was designed for the case where the incoming error comes from one of c's own descendant collectors — that error is already reachable from the root via tree auto-join, so re-counting it on c would produce duplicates.

However, the same branch also matched foreign *collected values: errors produced by an unrelated, parser-local fail-fast collector that is not a child of c. The canonical example in this repo:

• confgen.NewExtendedSheetParser creates its own xerrors.NewCollector(1) for in-sheet fail-fast diagnostics (internal/confgen/parser.go:333).
• When protogen.parseEnumTypeSheet (mode MODE_ENUM_TYPE_MULTI) calls into confgen and the sheet parser hits an error, confgen's local collector calls Join() and returns a *collected{origin: parserLocalCol} up the call chain.
• The outer protogen.go:716 does sheetCollector.Collect(xerrors.WrapKV(blockErr, KeyBookName, ..., KeySheetName, ...)).
• sheetCollector is built via bookCollector.NewChild(...) and has no parent relationship with parserLocalCol, so the short-circuit was firing on a foreign origin.

Net effect:

• The error was neither appended to sheetCollector.errs nor counted.
• outerWM was written onto the foreign collector (which sheetCollector.Join() never visits).
• sheetCollector.HasErrors() stayed false, Join() returned nil.
• The "sub-field value not unique" diagnostic (and any other confgen-surfaced error reaching protogen via parseEnumType / parseStructType) was silently swallowed and the tool exited 0 with no output.

Fix

Tighten the short-circuit so it only fires when the collected error's origin is part of c's own collector tree (shares the same root reachable via the parent chain).

if errors.As(err, &ce) && ce.origin != nil && ce.origin.sameTreeAs(c) {
    // same tree → reachable from root via auto-join; only record outerWM
    return nil
}
// otherwise fall through to the ordinary path: append + count

Two small helpers (root, sameTreeAs) are added to Collector. They are pure parent-chain walks, no locks needed.

Semantics after the fix

Collect(err) where err is *collected with origin oc:

Case	Behavior
oc is in the same collector tree as c (shares root)	Unchanged: record outer WrapKV fields on oc and return; do not double-count.
oc is foreign (different tree, e.g. parser-local fail-fast collector)	New: treat as an ordinary error — append to c.errs, bump every ancestor's counter. HasErrors() and Join() now surface it.

Tests

• Renamed two tests whose assertions encoded the buggy "silently drop foreign collected" behavior:

  • TestCollected_CollectSkipsCollectedError → TestCollected_CollectForeignCollectedIsNotDropped
  • TestCollected_CollectSkipsWrappedCollectedError → TestCollected_CollectForeignWrappedCollectedIsNotDropped

  Both now assert that the foreign (and WrapKV-wrapped foreign) collected error survives Collect and shows up in Join().

• TestCollected_CrossSubtreeCollection keeps its original assertion (same-tree siblings between outerChild / innerChild under docChild): outer must not re-count an inner sibling's *collected. The new same-tree predicate covers this case unchanged.

• All other internal/x/xerrors tests pass without modification.

Verification

$ go test -count=1 ./internal/x/xerrors/...
ok  	github.com/tableauio/tableau/internal/x/xerrors	0.016s

$ go test -count=1 ./...
ok  	github.com/tableauio/tableau/internal/confgen
ok  	github.com/tableauio/tableau/internal/protogen
ok  	github.com/tableauio/tableau/internal/x/xerrors
... (all packages green)

Compatibility

• Pure semantic widening: previously-dropped errors now surface. No callers in this repo relied on the dropped behavior; the renamed tests were the only place that asserted it.
• Same-tree behavior is bit-for-bit unchanged, so existing protogen / confgen / load happy paths and intentional sibling-aggregation patterns are unaffected.

[github-actions]

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
✅ passed	✅ passed	✅ passed	✅ passed	Jul 7, 2026, 9:55 AM

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.02%. Comparing base (9c744b8) to head (ddf484c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   74.95%   75.02%   +0.06%     
==========================================
  Files          88       88              
  Lines        9408     9416       +8     
==========================================
+ Hits         7052     7064      +12     
+ Misses       1784     1782       -2     
+ Partials      572      570       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.