split ruby_curl_easy_new function into separate allocate and initiali…#329
Merged
taf2 merged 1 commit intotaf2:masterfrom Jan 3, 2018
Merged
split ruby_curl_easy_new function into separate allocate and initiali…#329taf2 merged 1 commit intotaf2:masterfrom
taf2 merged 1 commit intotaf2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 0.9.4 does not allow a subclass to have different number or order of arguments to the base class.
E.g.
`class Derived < Curl::Easy
def initialize(url,foo,bar)
super(url)
end
end
c = Derived.new(nil,1,2)`
gives the following error:
in `new': wrong number of arguments (given 3, expected 0..1) (ArgumentError)
This modification splits ruby_curl_easy_new() into separate allocate and initialize functions
which allows the above code to work.
note some differences are just my editor removing trailing blanks from lines.