extconf.rb: Fix SSL versions constant names#333
Merged
taf2 merged 2 commits intotaf2:masterfrom Jan 3, 2018
Merged
Conversation
Signed-off-by: Julien 'Lta' BALLET <contact@lta.io>
Signed-off-by: Julien 'Lta' BALLET <contact@lta.io>
Contributor
Author
|
Ping @taf2 :) |
Collaborator
|
Your diff is a fucking carcrash, but your changes are good. In future please exclude your spacing issues because they make my brain hurt. Ty, Ross. |
Contributor
Author
|
I'm sure there was a nicer way to say this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
have_constantmethod puts the whole constant name to upcase, but the various ssl versions constants aren't fully upcase, so they're never found. This patch updates those constants to use a symbol with the right case.This PR also updates the README to reflect the need to run
rake compilebeforerake installto have the makefile generated.Sadly, the PR also includes a few spacing changes I was too lazy to remove, tell me if this is a problem.
Cheers,
Lta.
Signed-off-by: Julien 'Lta' BALLET contact@lta.io