fix(xls): ensure BIFF5 Lbl and ExternSheet records are parsed correctly#613
Merged
jmcnamara merged 1 commit intotafia:masterfrom Mar 6, 2026
Merged
fix(xls): ensure BIFF5 Lbl and ExternSheet records are parsed correctly#613jmcnamara merged 1 commit intotafia:masterfrom
Lbl and ExternSheet records are parsed correctly#613jmcnamara merged 1 commit intotafia:masterfrom
Conversation
alexander-beedie
changed the title
Lbl and ExternSheet records are not parsed as BIFF8Lbl and ExternSheet records are parsed correctly
alexander-beedie
force-pushed
the
fix-biff5
branch
2 times, most recently
from
d579531 to
934c1f7
Compare
Collaborator
|
Overall looks good. It is a good tidy-up as well as a fix. I'll do some additional testing and merge it is a couple of days. Ping @sftse in case you want to review too. |
alexander-beedie
force-pushed
the
fix-biff5
branch
4 times, most recently
from
5afca64 to
2b1c0e4
Compare
Contributor
Author
|
(Updated with a couple of -very- minor comment/docstring clarifications) |
Collaborator
|
This patchset has a conflict due to another patch that got merged before it. Could you resolve that and rebase when you get a chance. |
alexander-beedie
force-pushed
the
fix-biff5
branch
from
2b1c0e4 to
4c09ea2
Compare
Contributor
Author
No problem - done 👍 Also updated the test in the previous PR with the suggested tweaks while rebasing/resolving (adding the associated issue number and a brief explanation). |
jmcnamara
pushed a commit
that referenced
this pull request
Mar 7, 2026
Repository owner
deleted a comment from
alexander-beedie
Mar 7, 2026
Repository owner
deleted a comment from
alexander-beedie
Mar 7, 2026
Collaborator
|
Merged. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #612.
LblandExternSheetrecord types (the error was caused by the code assuming BIFF8 byte layouts).