fix(vba): update check_variable_record to handle records that are optional#614
Merged
jmcnamara merged 1 commit intotafia:masterfrom Mar 6, 2026
Merged
Conversation
alexander-beedie
changed the title
check_variable_record to handle records that are optionalcheck_variable_record to handle records that are optional
alexander-beedie
force-pushed
the
fix-optional-records
branch
6 times, most recently
from
a9f10bc to
668414d
Compare
alexander-beedie
force-pushed
the
fix-optional-records
branch
from
668414d to
29560f2
Compare
jmcnamara
reviewed
Mar 6, 2026
Collaborator
|
Merged. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #581.
NameUnicodeRecord.check_variable_recordto account for this (ReadOnlyRecordandPrivateRecordare also optional, but they're fixed-size and their optionality is handled in theread_modulesloop).read_modulesloop (including expected size) to help future referencing.Footnotes
Reference: 2.3.4.2.3.2 MODULE Record ↩