Fix empty text after trimming whitespace - #993
Closed
lntutor wants to merge 1 commit into
Closed
Conversation
lntutor
marked this pull request as draft
July 30, 2026 13:55
lntutor
marked this pull request as ready for review
July 30, 2026 14:06
Contributor
Author
|
Closing as a duplicate of #986, which was already open for the same reported behavior. Sorry for the overlap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config::trim_text_endpromises not to emit a text event when trimming leaves it empty, but whitespace-only text immediately before markup still producedText("").This change lets both slice and buffered readers skip those whitespace-only spans before constructing an event.
read_to_endtemporarily disables both start and end trimming so its byte-range accounting remains unchanged.Regression coverage exercises both
Reader::from_strand bufferedReader::from_reader.Verification:
cargo fmt --all -- --checkcargo test skips_whitespace_only_text_before_markup --all-featurescargo test --all-featuresgit diff --checkCloses #984