fix: prevent overwriting existing agent models#1494
Conversation
github-actions
Bot
added
the
type: fix
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
tusharmath
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| fn test_subscriptions_with_matching_agents() { | ||
| use pretty_assertions::assert_eq; | ||
|
|
||
| // Arrange |
There was a problem hiding this comment.
There appears to be an inconsistency in the test assertion on line 785. The test comment on line 769 correctly states "Check that agent1's compact.model was not overridden to the workflow model", but the assertion for agent1.model still expects it to equal ModelId::new("workflow-model").
This contradicts the new behavior where existing models should be preserved. The assertion should verify that agent1.model maintains its original value (which appears to be "old-agent-model" based on the agent initialization), rather than being overwritten with the workflow model.
To align with the intended behavior change, this assertion should be updated to check that the agent's original model is preserved.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
1 participant
fixes #1440