Closed
Conversation
xihale
added a commit
to xihale/forgecode
that referenced
this pull request
Apr 26, 2026
…uplicate path resolution - ExternalHookInterceptor now holds Arc<Vec<PreparedHook>> instead of cloning hook content on every call (tailcallhq#14) - PreparedHook pre-creates the executable (memfd on Linux, temp-file elsewhere) at construction time, eliminating the per-call memfd create/seal overhead (tailcallhq#16) and the fd-lifetime race condition (tailcallhq#17) - The memfd guard is kept alive for the entire session, ensuring /proc/self/fd/N remains valid for all spawn() calls - Non-Linux temp files are cleaned up in PreparedHook::drop (tailcallhq#15) - Add validate_hook_path_for_delete() that works with missing files, allowing cleanup of stale trust-store entries (tailcallhq#18) - Extract resolve_and_validate_hook_path() helper in ui.rs to deduplicate ~40 lines of identical path resolution logic between trust and delete handlers (tailcallhq#13) - Add clarifying comment on Orchestrator.cached_hooks explaining the dual propagation path (primary via Hook, sub-agents via context) (tailcallhq#20) - Log the corrupted file path in TrustStore::load() so users can recover their data before it's overwritten (tailcallhq#5) - Remove committed plan files (working documents with unchecked tasks) (tailcallhq#19) Co-Authored-By: ForgeCode <noreply@forgecode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.