refactor: migrate from content-based to event-based communication model - #446
Merged
Conversation
github-actions
Bot
added
the
type: chore
This PR refactors the communication model in forge to use explicit events instead of raw content strings. Key changes include: - Replace ChatRequest.content with Event object - Simplify ForgeExecutor by removing environment and tool services - Move event type constants from domain layer to UI layer - Update Orchestrator to use direct event dispatch - Add input field to Transform::User for bidirectional communication - Update tests and integration to use new event-based API This refactoring simplifies the code and makes the event flow more explicit across the system.
tusharmath
force-pushed
the
add-diff-output-to-apply-json
branch
from
March 4, 2025 07:55
234c07e to
743b254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the communication model in forge to use explicit events instead of raw content strings. The change makes the event flow more explicit across the system and simplifies the codebase.
Changes
Testing
Most tests pass, though there are some integration test failures related to tracing initialization which should be addressed separately. These failures are not directly caused by the code changes in this PR.
Additional Notes
This refactoring is part of a larger effort to simplify the system architecture and make the code more maintainable.