android: fix health warnings sort order#789
Merged
Merged
Conversation
nickkhyl
approved these changes
May 13, 2026
Comment on lines
+51
to
+52
| // Otherwise, alphabetical by title | ||
| return Title.compareTo(other.Title) |
Member
There was a problem hiding this comment.
I'm not sure whether this should be Title or WarnableCode.
I think WarnableCode makes a bit more sense, since the Title can theoretically change during the issue's lifecycle.
That said, in practice, we don't currently do that. So I guess either is fine?
Collaborator
Author
There was a problem hiding this comment.
Yeah, I wasn't sure either. Let's go with WarnableCode
This changes the comparator to sort by severity first (descending), ImpactsConnectivity as a secondary sort, and title as a final tiebreaker. This fixes the issue where the comparator was sorting ascending, and matches the new WinUI sorting behavior. Fixes tailscale/corp#41733 Signed-off-by: kari-ts <kari@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the comparator to sort by severity first (descending), ImpactsConnectivity as a secondary sort, and title as a final tiebreaker. This fixes the issue where the comparator was sorting ascending, and matches the new WinUI sorting behavior.
Fixes tailscale/corp#41733