client/web: add eslint #10409
Merged
client/web: add eslint #10409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnorris
reviewed
Nov 28, 2023
There was a problem hiding this comment.
wow, that's a lot of new js dependencies! Of course, I know we're only using them during development.
Which also makes me wonder if it matters whether we're declaring these as runtime deps vs dev deps. I suspect not, since everything is effectively a dev dependency... we just don't happen to have them declared under devDependencies. 🤷🏻
willnorris
approved these changes
Nov 28, 2023
Ugh I know it pretty much doubled the yarn lock size |
Add eslint to require stricter typescript rules, particularly around required hook dependencies. This commit also updates any files that were now throwing errors with eslint. Updates #10261 Signed-off-by: Sonia Appasamy <sonia@tailscale.com>
soniaappasamy
force-pushed
the
soniaappasamy/add-eslint-web-client
branch
from
8fe568f to
d5b9cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eslint to require stricter typescript rules, particularly around required hook dependencies. This commit also updates any files that were now throwing errors with eslint.
Updates #10261