cmd/k8s-operator/deploy/chart: allow reading OAuth creds from a CSI driver's volume and annotating operator's Service account#14264
Merged
irbekrm merged 4 commits intotailscale:mainfrom Dec 3, 2024
Conversation
oliverrahner
force-pushed
the
main
branch
2 times, most recently
from
5ec913f to
44e7cea
Compare
irbekrm
suggested changes
Dec 3, 2024
Contributor
irbekrm
left a comment
irbekrm
left a comment
There was a problem hiding this comment.
Thank you for working on this @oliverrahner , this looks neat and makes sense.
I've left two comments, additionally could you please reference an issue number on the commit message to pass our CI bot, see an example 9f9063e
Updates tailscale#14264 Signed-off-by: Oliver Rahner <o.rahner@dke-data.com>
Updates tailscale#14264 Signed-off-by: Oliver Rahner <o.rahner@dke-data.com>
Updates tailscale#14264 Signed-off-by: Oliver Rahner <o.rahner@dke-data.com>
Updates tailscale#14264 Signed-off-by: Oliver Rahner <o.rahner@dke-data.com>
irbekrm
changed the title
irbekrm
approved these changes
Dec 3, 2024
Contributor
irbekrm
left a comment
irbekrm
left a comment
There was a problem hiding this comment.
Thank you @oliverrahner !
Contributor
|
@oliverrahner I've cut a dev Helm chart with your change - |
Contributor
Author
|
Well, that was one of the quickest PR reviews I ever had :) Thanks a bunch! |
thirdeyenick
pushed a commit
to ninech/tailscale
that referenced
this pull request
Jul 2, 2025
…river's volume and annotating operator's Service account (tailscale#14264) cmd/k8s-operator/deploy/chart: allow reading OAuth creds from a CSI driver's volume and annotating operator's Service account Updates tailscale#14264 Signed-off-by: Oliver Rahner <o.rahner@dke-data.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #11270 / #12213
It does intentionally not follow the
extraVolumes/extraMountspattern to increase ease-of-use, but solves the very specific problem of using secrets-store-csi-driver.Not setting the new object results in falling back to the previous default behavior.