cmd/mkpkg: support adding empty directories.#350
Merged
Conversation
dshynkev
force-pushed
the
dshynkev/mkpkg-emptydirs
branch
from
7e68b2f to
10de7fc
Compare
Signed-off-by: Dmytro Shynkevych <dmytro@tailscale.com>
dshynkev
force-pushed
the
dshynkev/mkpkg-emptydirs
branch
from
10de7fc to
a24e72a
Compare
danderson
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eventually fixes #341, pending update to the packaging script.
As suggested in this comment, it turns out that adding an empty directory at
/var/cache/tailscaleto the%filessection of the rpm package fixes the issue (tested on a clean CentOS 8.1.1911 VM).Since this may be useful for other directories in the future, this patch implements a generic way of adding empty directories to a package. In particular, it works for an empty list of empty directories, which is the default. This is not the case for
--filesand--configs, which always expect a nonempty list as an argument; hence the special treatment of""inparseEmptyDirs.