Provide a safer and future-proofed system font stack#353
Merged
adamwathan merged 1 commit intotailwindlabs:masterfrom Jan 15, 2018
nternetinspired:master
Merged
Provide a safer and future-proofed system font stack#353adamwathan merged 1 commit intotailwindlabs:masterfrom nternetinspired:master
adamwathan merged 1 commit intotailwindlabs:masterfrom
nternetinspired:master
Conversation
|
system-ui is not supported in IE11 and Edge |
Contributor
Author
|
Correct @sgraewe but thats's kinda irrelevant, and why it's sensible to declare a font stack rather than a single family in the first place; a browser that doesn't understand it will just skip it and move on to the next one. It's perfectly valid stack declaration, and causes no issues, for either Edge or IE; The only issues with using such a stack in IE is with using the -apple-system keyword first, the issue that this PR will resolve by transposing the keywords, as described above. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hey guys!
This PR brings two discrete additions:
By transposing
system-uiandBlinkMacSystemFontkeywords, it eliminates the potential for issue which may occur if the font-stack were used in a shorthand declaration, as that causes IE and Edge to choke at-apple-systemand ignore the entire declaration. See Implementing system fonts on Booking.com — A lesson learned for full details.Future proofs the stack by adding support for the newer, unprefixed, SystemUI font-family keyword that was introduced with Chrome 56 with the aim of providing a standard, cross-browser implementation.
Thanks for your consideration.
Absolutely loving Tailwind so far, keep up the great work!