-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add the word "flexbox" to all flexbox doc pages #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@maxiloc @LukyVj Gents, I hope you don't mind me bugging you one more time about the Algolia DocSearch on our site. As you can see from this proposed PR, we're running into a situation where searching for "flexbox" does not return any of our flexbox pages:
The reason, as noted above, is quite simple: the word "flexbox" does not actually exist on those pages. The problem with this PR is that we're actually not using the proper language for flexbox. For example, while the spec is called "flexbox", "flexbox containers" are not a thing—they are actually "flex containers". My question is simple: is there a way for us to add keywords to a page via meta tags or something, without actually having those words on the page? Or maybe you have another recommendation on how to handle this? Thanks! |
|
I updated the config so it take the infos from the sidebar. That should fix the issue. Tell me if that's good for you. |
|
@maxiloc Incredible! 👯 |
Fix an error
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @emnapi/runtime (1.5.0 → 1.6.0) · [Repo](https://github.com/toyobayashi/emnapi) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/toyobayashi/emnapi/releases/tag/v1.6.0">1.6.0</a></h4> <blockquote><h2 dir="auto">What's Changed</h2> <ul dir="auto"> <li>feat: added SharedArrayBuffer api by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/171">#171</a> </li> <li>feat: make napi_delete_reference use node_api_basic_env by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/170">#170</a> </li> <li>ci: migrate to npm trusted publishing by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/168">#168</a> </li> </ul> <p dir="auto"><strong>Full Changelog</strong>: <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/compare/v1.5.0...v1.6.0"><tt>v1.5.0...v1.6.0</tt></a></p></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/@emnapi%2Fruntime/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href="https://github.com/toyobayashi/emnapi/compare/61628bd5e27679955f13cbff8f6573d66a5fc00c...86d68f88ec3cc3949a555c93a633fa8997534413">See the full diff on Github</a>. The new version differs by 4 commits:</p> <ul> <li><a href="https://github.com/toyobayashi/emnapi/commit/86d68f88ec3cc3949a555c93a633fa8997534413"><code>1.6.0</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/100b8a358091a930cb189081f4dd900dc6bf2998"><code>feat: make napi_delete_reference use node_api_basic_env (#170)</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/bf622fc37b250c05e31629bc7591aeb4cdb48415"><code>[Backport] feat: added SharedArrayBuffer api (#171)</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/971e3d9e37e0157e26cf4906c230cd3dd2072393"><code>ci: migrate to npm trusted publishing (#168)</code></a></li> </ul> </details> ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ emnapi (1.5.0 → 1.6.0) · [Repo](https://github.com/toyobayashi/emnapi) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/toyobayashi/emnapi/releases/tag/v1.6.0">1.6.0</a></h4> <blockquote><h2 dir="auto">What's Changed</h2> <ul dir="auto"> <li>feat: added SharedArrayBuffer api by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/171">#171</a> </li> <li>feat: make napi_delete_reference use node_api_basic_env by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/170">#170</a> </li> <li>ci: migrate to npm trusted publishing by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/168">#168</a> </li> </ul> <p dir="auto"><strong>Full Changelog</strong>: <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/compare/v1.5.0...v1.6.0"><tt>v1.5.0...v1.6.0</tt></a></p></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/emnapi/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href="https://github.com/toyobayashi/emnapi/compare/61628bd5e27679955f13cbff8f6573d66a5fc00c...86d68f88ec3cc3949a555c93a633fa8997534413">See the full diff on Github</a>. The new version differs by 4 commits:</p> <ul> <li><a href="https://github.com/toyobayashi/emnapi/commit/86d68f88ec3cc3949a555c93a633fa8997534413"><code>1.6.0</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/100b8a358091a930cb189081f4dd900dc6bf2998"><code>feat: make napi_delete_reference use node_api_basic_env (#170)</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/bf622fc37b250c05e31629bc7591aeb4cdb48415"><code>[Backport] feat: added SharedArrayBuffer api (#171)</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/971e3d9e37e0157e26cf4906c230cd3dd2072393"><code>ci: migrate to npm trusted publishing (#168)</code></a></li> </ul> </details> ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ @emnapi/core (1.5.0 → 1.6.0) · [Repo](https://github.com/toyobayashi/emnapi) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/toyobayashi/emnapi/releases/tag/v1.6.0">1.6.0</a></h4> <blockquote><h2 dir="auto">What's Changed</h2> <ul dir="auto"> <li>feat: added SharedArrayBuffer api by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/171">#171</a> </li> <li>feat: make napi_delete_reference use node_api_basic_env by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/170">#170</a> </li> <li>ci: migrate to npm trusted publishing by <a href="https://bounce.depfu.com/github.com/toyobayashi">@toyobayashi</a> in <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/pull/168">#168</a> </li> </ul> <p dir="auto"><strong>Full Changelog</strong>: <a href="https://bounce.depfu.com/github.com/toyobayashi/emnapi/compare/v1.5.0...v1.6.0"><tt>v1.5.0...v1.6.0</tt></a></p></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/@emnapi%2Fcore/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href="https://github.com/toyobayashi/emnapi/compare/61628bd5e27679955f13cbff8f6573d66a5fc00c...86d68f88ec3cc3949a555c93a633fa8997534413">See the full diff on Github</a>. The new version differs by 4 commits:</p> <ul> <li><a href="https://github.com/toyobayashi/emnapi/commit/86d68f88ec3cc3949a555c93a633fa8997534413"><code>1.6.0</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/100b8a358091a930cb189081f4dd900dc6bf2998"><code>feat: make napi_delete_reference use node_api_basic_env (#170)</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/bf622fc37b250c05e31629bc7591aeb4cdb48415"><code>[Backport] feat: added SharedArrayBuffer api (#171)</code></a></li> <li><a href="https://github.com/toyobayashi/emnapi/commit/971e3d9e37e0157e26cf4906c230cd3dd2072393"><code>ci: migrate to npm trusted publishing (#168)</code></a></li> </ul> </details> ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Right now when you search for "flexbox" in the Tailwind docs you don't see any of the flexbox pages, since they don't actually say "flexbox" anywhere.
This PR simply changes "flex" to "flexbox" in the description of each page, which will fix this. I thought the description might be the best place to add this because the snippet shown in the search will likely end up being very useful.