Improve canonicalization for & > :pseudo and & :pseudo arbitrary variants
#19178
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feat/canonicalize-more-stars
branch
from
259bbb9 to
934b2d0
Compare
RobinMalfait
approved these changes
Oct 22, 2025
thecrypticace
force-pushed
the
feat/canonicalize-more-stars
branch
from
934b2d0 to
dd1ddf2
Compare
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves canonicalization of arbitrary variants that use pseudo classes a bit.
Before this we would see
[&_:first-child]:flexand leave it be when it can instead be written as**:first:flex. Likewise, for pseudo classes that don't have a variant, we can still simplify things a bit as[&_:--custom]can be written**:[:--custom].