Skip comments in Ruby files when checking for class names by thecrypticace · Pull Request #19243 · tailwindlabs/tailwindcss

thecrypticace · 2025-10-31T16:42:14Z

Fixes #19239

crates/oxide/src/extractor/pre_processors/ruby.rs

coderabbitai · 2025-11-11T20:57:07Z

Walkthrough

Adds an Exclamation enum variant and updates the arbitrary-property parser to treat a top-level exclamation mark as invalid (e.g. [color:red!], [color:red!important]). Enhances the Ruby pre-processor to skip single- and double-quoted string contents with backslash escapes, convert # comments to spaces until newline, and refine %w, %W, %p delimiter handling using a bracket stack and adjusted space/newline boundary rules. Removes nonfunctional annotation lines from a HAML test fixture and adds CHANGELOG entries for the Ruby comment and top-level ! changes.

Pre-merge checks

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Skip comments in Ruby files when checking for class names' accurately reflects the primary change in the PR—improved Ruby preprocessor comment handling.
Description check	✅ Passed	The description 'Fixes #19239' is concise and references the linked issue that provides full context about the PR's objectives.
Linked Issues check	✅ Passed	The PR addresses issue #19239 by skipping RDoc comments in Ruby files (ruby.rs) and handling top-level exclamation marks in arbitrary properties (arbitrary_property_machine.rs), both of which suppress the parsing warnings described in the issue.
Out of Scope Changes check	✅ Passed	All changes are in-scope: improved Ruby comment/string handling, top-level exclamation mark detection for arbitrary properties, fixture cleanup, and changelog updates directly address the RDoc parsing warning issue.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between defb469 and 5ae0787.

📒 Files selected for processing (1)

CHANGELOG.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

CHANGELOG.md

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3cece1d and c19d255.

📒 Files selected for processing (3)

crates/oxide/src/extractor/arbitrary_property_machine.rs (3 hunks)
crates/oxide/src/extractor/pre_processors/ruby.rs (5 hunks)
crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml (0 hunks)

💤 Files with no reviewable changes (1)

crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml

🧰 Additional context used

🧬 Code graph analysis (1)

crates/oxide/src/extractor/pre_processors/ruby.rs (2)

crates/oxide/src/extractor/candidate_machine.rs (1)

next (29-169)

crates/oxide/src/extractor/string_machine.rs (1)

next (32-68)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: Linux
GitHub Check: Linux / postcss
GitHub Check: Linux / vite
GitHub Check: Linux / upgrade

crates/oxide/src/extractor/arbitrary_property_machine.rs

RobinMalfait

Looks good, but not sure about the !important.

Can you also add a changelog entry?

crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml

crates/oxide/src/extractor/arbitrary_property_machine.rs

thecrypticace · 2025-11-12T15:41:09Z

Yeah I was not gonna change that part. It's unrelated anyway. Will get the change log updated.

Unless it’s part of `!important` at the end

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c19d255 and f381118.

📒 Files selected for processing (4)

CHANGELOG.md (1 hunks)
crates/oxide/src/extractor/arbitrary_property_machine.rs (3 hunks)
crates/oxide/src/extractor/pre_processors/ruby.rs (5 hunks)
crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml (0 hunks)

💤 Files with no reviewable changes (1)

crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml

🧰 Additional context used

🧬 Code graph analysis (1)

crates/oxide/src/extractor/pre_processors/ruby.rs (2)

crates/oxide/src/extractor/candidate_machine.rs (1)

next (29-169)

crates/oxide/src/extractor/string_machine.rs (1)

next (32-68)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

GitHub Check: Linux
GitHub Check: Linux / cli
GitHub Check: Linux / upgrade
GitHub Check: Linux / postcss
GitHub Check: Linux / vite
GitHub Check: Linux / webpack

crates/oxide/src/extractor/pre_processors/ruby.rs

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [@tailwindcss/postcss](https://tailwindcss.com) ([source](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/@tailwindcss-postcss)) | [`4.1.17` -> `4.1.18`](https://renovatebot.com/diffs/npm/@tailwindcss%2fpostcss/4.1.17/4.1.18) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@tailwindcss%2fpostcss/4.1.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@tailwindcss%2fpostcss/4.1.17/4.1.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tailwindlabs/tailwindcss (@tailwindcss/postcss)</summary> ### [`v4.1.18`](https://github.com/tailwindlabs/tailwindcss/blob/HEAD/CHANGELOG.md#4118---2025-12-11) [Compare Source](tailwindlabs/tailwindcss@v4.1.17...v4.1.18) ##### Fixed - Ensure validation of `source(…)` happens relative to the file it is in ([#19274](tailwindlabs/tailwindcss#19274)) - Include filename and line numbers in CSS parse errors ([#19282](tailwindlabs/tailwindcss#19282)) - Skip comments in Ruby files when checking for class names ([#19243](tailwindlabs/tailwindcss#19243)) - Skip over arbitrary property utilities with a top-level `!` in the value ([#19243](tailwindlabs/tailwindcss#19243)) - Support environment API in `@tailwindcss/vite` ([#18970](tailwindlabs/tailwindcss#18970)) - Preserve case of theme keys from JS configs and plugins ([#19337](tailwindlabs/tailwindcss#19337)) - Write source maps correctly on the CLI when using `--watch` ([#19373](tailwindlabs/tailwindcss#19373)) - Handle special defaults (like `ringColor.DEFAULT`) in JS configs ([#19348](tailwindlabs/tailwindcss#19348)) - Improve backwards compatibility for `content` theme key from JS configs ([#19381](tailwindlabs/tailwindcss#19381)) - Upgrade: Handle `future` and `experimental` config keys ([#19344](tailwindlabs/tailwindcss#19344)) - Try to canonicalize any arbitrary utility to a bare value ([#19379](tailwindlabs/tailwindcss#19379)) - Validate candidates similarly to Oxide ([#19397](tailwindlabs/tailwindcss#19397)) - Canonicalization: combine `text-*` and `leading-*` classes ([#19396](tailwindlabs/tailwindcss#19396)) - Correctly handle duplicate CLI arguments ([#19416](tailwindlabs/tailwindcss#19416)) - Don’t emit color-mix fallback rules inside `@keyframes` ([#19419](tailwindlabs/tailwindcss#19419)) - CLI: Don't hang when output is `/dev/stdout` ([#19421](tailwindlabs/tailwindcss#19421)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.csmpro.ru/csmpro/mapban/pulls/74 Co-authored-by: Renovate Bot <renovate@csmpro.ru> Co-committed-by: Renovate Bot <renovate@csmpro.ru>

Fixes: #19481 This PR improves the Ruby extractor to better handle strict locals. We recently introduced skipping comments in the Ruby extractor (PR #19243 for #19239) by ignoring comments that start with `#` until the end of the line. Strict locals are implemented like this: ```ruby <%# locals: (css: "text-amber-600") %> ``` Notice the `#` after the `<%`, we considered this a comment and ignored it. This PR changes that behavior slightly where we skip comments that are preceded by `%`. This means that `<%# anything here _will_ be scanned %>`. This should solve the strict locals case, and normal comments will still be skipped. We can be more strict in the future if needed, but I think that this should be a good solution for both scenarios. ### Test plan 1. Added a test to ensure we extract candidates in strict locals 2. Added a regression test for issue #19239 where we introduced skipping comments in the Ruby extractor 3. Other existing tests are still passing We can also verify the extracted candidates: (it's subtle, but you can see that the class is being extracted now) <img width="1187" height="1376" alt="image" src="https://github.com/user-attachments/assets/74bbfd79-9db4-4a5b-bd8d-25f1565c6bfd" />

thecrypticace force-pushed the fix/issue-19239 branch from bc1c637 to fa2be75 Compare October 31, 2025 16:42

thecrypticace marked this pull request as ready for review October 31, 2025 18:21

thecrypticace requested a review from a team as a code owner October 31, 2025 18:21

RobinMalfait reviewed Nov 3, 2025

View reviewed changes

crates/oxide/src/extractor/pre_processors/ruby.rs Show resolved Hide resolved

coderabbitai bot reviewed Nov 11, 2025

View reviewed changes

crates/oxide/src/extractor/arbitrary_property_machine.rs Outdated Show resolved Hide resolved

RobinMalfait requested changes Nov 12, 2025

View reviewed changes

crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml Show resolved Hide resolved

crates/oxide/src/extractor/arbitrary_property_machine.rs Outdated Show resolved Hide resolved

thecrypticace added 9 commits November 12, 2025 12:14

Skip over strings in Ruby files

5c54516

Replace comments in Ruby code

54617bc

Discard arbitrary properties with ! at the top-level

a413e53

Unless it’s part of `!important` at the end

Fix formatting

956ce18

Add tests

d9163d8

Support single line string literal specifiers

3778c28

Only match expected string literal specifiers

14f888f

Fix formatting

5662aaf

Update changelog

f381118

thecrypticace force-pushed the fix/issue-19239 branch from 42f48be to f381118 Compare November 12, 2025 17:15

coderabbitai bot reviewed Nov 12, 2025

View reviewed changes

crates/oxide/src/extractor/pre_processors/ruby.rs Show resolved Hide resolved

Handle # as a string format delimiter

7f34f3f

RobinMalfait approved these changes Nov 13, 2025

View reviewed changes

thecrypticace added 3 commits November 13, 2025 05:41

Remove !important thing

54d4cac

Update comment

defb469

Update changelog

5ae0787

thecrypticace merged commit 4455051 into main Nov 13, 2025
7 checks passed

thecrypticace deleted the fix/issue-19239 branch November 13, 2025 10:53

This was referenced Dec 11, 2025

chore(deps): update dependency tailwindcss to 4.1.18 cwcss/crosswind#8

Closed

chore(deps): update all non-major dependencies cwcss/crosswind#12

Closed

This was referenced Dec 11, 2025

chore(deps): update all non-major dependencies stacksjs/ts-maps#479

Closed

chore(deps): update all non-major dependencies stacksjs/ts-maps#489

Closed

chrisbbreuer mentioned this pull request Dec 22, 2025

chore(deps): update all non-major dependencies stacksjs/ts-maps#493

Closed

1 task

coderabbitai bot mentioned this pull request Dec 24, 2025

Class extraction with Rails' strict locals #19481

Closed

RobinMalfait mentioned this pull request Jan 5, 2026

Fix class extraction for Rails' strict locals #19525

Merged

This was referenced Jan 15, 2026

chore(deps): update all non-major dependencies stacksjs/ts-maps#508

Closed

chore(deps): update all non-major dependencies stacksjs/ts-maps#509

Closed

chore(deps): update all non-major dependencies stacksjs/ts-maps#510

Closed

ganyicz mentioned this pull request Jan 15, 2026

Date picker - Selectable header caret livewire/flux#2311

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip comments in Ruby files when checking for class names#19243

Skip comments in Ruby files when checking for class names#19243
thecrypticace merged 13 commits intomainfrom
fix/issue-19239

thecrypticace commented Oct 31, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

RobinMalfait left a comment

Uh oh!

Uh oh!

Uh oh!

thecrypticace commented Nov 12, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

thecrypticace commented Oct 31, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Pre-merge checks

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RobinMalfait left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thecrypticace commented Nov 12, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Nov 11, 2025 •

edited

Loading