v3: Don’t break sibling-*() functions when used inside calc(…)
#19335
+216
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
approved these changes
Nov 19, 2025
Member
RobinMalfait
left a comment
RobinMalfait
left a comment
There was a problem hiding this comment.
Going to approve it, but I wonder how hard it would be to backport the v4 implementation instead which should handle this (and future functions) 🤔
Contributor
Author
|
@RobinMalfait I added a thing to handle custom functions as well but yeah maybe could backport from v4. Lemme look into that to see what it'd be like. 🤔 |
Contributor
Author
|
@RobinMalfait ported that from v4 👍 |
RobinMalfait
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of v3's math operator normalization uses a safe-list of function names. Need to add
sibling-index()andsibling-count()to this list otherwise when used inside math functions likecalc()they'll get spaces around the-.