Make docs config compatible with older versions of node #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhemphill
approved these changes
Nov 3, 2017
adamwathan
reviewed
Nov 3, 2017
| config.colors = { | ||
| ...config.colors, | ||
|
|
||
| config.colors = Object.assign(config.colors, { |
Member
There was a problem hiding this comment.
Object.assign mutates the first object in the parameter list, so it isn't technically required to assign this back to the property. I can't decide if I think it's harmless or misleading.
If you want to do this in an immutable way, you can rewrite it like:
config.colors = Object.assign({}, config.colors, { ... })
Note the extra empty anonymous object as the first param.
Member
There was a problem hiding this comment.
Also this is just the docs config file so who fucking cares.
adamwathan
deleted the
make-docs-config-compatible-with-older-versions-of-node
branch
DCzajkowski
pushed a commit
to DCzajkowski/tailwindcss
that referenced
this pull request
Jul 23, 2019
…grow-0 Rename the `flex-no-[grow/shrink]` classnames to `flex-[grow/shrink]-0` (tailwindlabs#687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the rest operator (
...) from the documentation's Tailwind config, making it possible to build the docs on older versions of Node.