fix(rtl): correctly picking up new values - #48
Merged
Conversation
|
do you mind sharing a bit on why this fixes the issue? seems like the vrt looks exactly the same. could we create a previously failing test? |
Contributor
Author
sure, let me update the PR |
Contributor
Author
|
@chasestarr - not sure if this better clarifies the issue, please let me know if you'd like to see more of a reproduction in the base web context, you can see a repro here: https://github.com/uber/baseweb/issues/2180 |
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/uber/baseweb/issues/2180