Skip to content

feat(platform): add member count and created date to teams table#1556

Merged
Israeltheminer merged 3 commits into
mainfrom
feat/teams-table-member-count-created
Apr 16, 2026
Merged

feat(platform): add member count and created date to teams table#1556
Israeltheminer merged 3 commits into
mainfrom
feat/teams-table-member-count-created

Conversation

@Israeltheminer
Copy link
Copy Markdown
Collaborator

@Israeltheminer Israeltheminer commented Apr 16, 2026

Summary

  • Extend getMyTeams and listOrgTeams Convex queries to return memberCount and createdAt for each team
  • Add member count and relative created date columns to the teams settings table
  • Add TeamMembersPreloader component to eagerly subscribe to team member data, so detail/edit/delete dialogs open instantly
  • Wrap teams table in PageSection for consistent settings page layout
  • Update all test fixtures and mocks to include the new fields

Test plan

  • Verify teams table shows member count and relative created date columns
  • Open team detail/edit/delete dialogs and confirm data loads instantly (no spinner)
  • Run convex/members/__tests__/queries.test.ts — all tests pass
  • Run teams table component tests — all pass
  • Verify layout matches other settings page sections

Summary by CodeRabbit

  • New Features
    • Teams table now displays member count for each team
    • Teams table now shows team creation date with relative time formatting

Extend team queries (getMyTeams, listOrgTeams) to return memberCount and
createdAt alongside id/name. Add member count and relative created date
columns to the teams table. Wrap the table in PageSection for consistent
layout. Add TeamMembersPreloader to eagerly subscribe to team member data
so detail/edit/delete dialogs open instantly. Update test fixtures to
include the new fields and mock the member count queries.
The TeamMembersPreloader component uses useTeamMembers which requires a
QueryClient. Add a mock to prevent the "No QueryClient set" error in tests.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f4c62092-a3f3-4c21-b489-c8919a0dd692

📥 Commits

Reviewing files that changed from the base of the PR and between ee01033 and ca6c886.

📒 Files selected for processing (7)
  • services/platform/app/features/settings/teams/components/team-delete-dialog.test.tsx
  • services/platform/app/features/settings/teams/components/team-row-actions.test.tsx
  • services/platform/app/features/settings/teams/components/teams-table.test.tsx
  • services/platform/app/features/settings/teams/components/teams-table.tsx
  • services/platform/app/features/settings/teams/hooks/use-teams-table-config.tsx
  • services/platform/convex/members/__tests__/queries.test.ts
  • services/platform/convex/members/queries.ts

📝 Walkthrough

Walkthrough

This PR extends team data returned by backend queries to include memberCount and createdAt fields. The Convex queries getMyTeams and listOrgTeams are modified to compute member counts via parallel teamMember lookups and include creation timestamps in results. The frontend teams table is updated to display these new fields as additional columns and to eagerly preload team member data. Test fixtures are updated throughout to populate the new fields, and a mock for team member queries is added to test dependencies.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/teams-table-member-count-created

Comment @coderabbitai help to get the list of available commands and usage tips.

@Israeltheminer Israeltheminer merged commit 0b0347c into main Apr 16, 2026
8 of 9 checks passed
@Israeltheminer Israeltheminer deleted the feat/teams-table-member-count-created branch April 16, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant