chore(workflow): move all jobs to free GitHub-hosted runners#1674
Merged
Conversation
The repo is public, so ubuntu-latest is free. Move CI jobs that don't benefit from Blacksmith's sticky Docker layer cache off Blacksmith to cut spend without slowing the critical path. Migrated to ubuntu-latest: - lint.yml: lint, format, knip - test.yml: test (unit) - commitlint.yml - security.yml: bun-audit, trivy-fs - build.yml: changes, storybook - release.yml: prepare, manifest, create-release, trigger-cli, summary - cli.yml: prepare, build (linux), release Stays on Blacksmith (Docker layer cache or memory-sensitive): - lint.yml typecheck, test.yml test-ui - build.yml build, smoke-test, image-validate, vulnerability-scan - release.yml build (amd64+arm64), container-test
Contributor
📝 WalkthroughWalkthroughThis PR updates GitHub Actions workflow configurations across seven workflow files. The changes include: (1) replacing custom Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/lint.yml (1)
115-119:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winStale comment still references "4vCPU" after the runner was downgraded to 2vCPU
The inline comment says "Memory-sensitive, keep at 4vCPU" but the runner is now
blacksmith-2vcpu-ubuntu-2404.✏️ Proposed fix
- # tsc --noEmit across workspaces. Memory-sensitive, keep at 4vCPU. + # tsc --noEmit across workspaces. Memory-sensitive, keep at 2vCPU.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/lint.yml around lines 115 - 119, The inline comment above the typecheck job is outdated (it says "keep at 4vCPU") while the job now uses runner "blacksmith-2vcpu-ubuntu-2404"; update the comment associated with the typecheck job (the block around the typecheck job name "Type check" / job key "typecheck") to reflect the current 2vCPU runner (or remove the stale note entirely) so the comment matches the runner configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/test.yml:
- Line 86: actionlint is flagging the custom runner label
blacksmith-2vcpu-ubuntu-2404 (and blacksmith-2vcpu-ubuntu-2404-arm) as unknown;
update the Actionlint configuration (.github/actionlint.yaml) to add these
strings to the known self-hosted runner labels so actionlint stops reporting
false positives—add both "blacksmith-2vcpu-ubuntu-2404" and
"blacksmith-2vcpu-ubuntu-2404-arm" to the self-hosted/labels list referenced by
actionlint so workflows that use runs-on: blacksmith-2vcpu-ubuntu-2404 (and the
ARM variant) are accepted.
---
Outside diff comments:
In @.github/workflows/lint.yml:
- Around line 115-119: The inline comment above the typecheck job is outdated
(it says "keep at 4vCPU") while the job now uses runner
"blacksmith-2vcpu-ubuntu-2404"; update the comment associated with the typecheck
job (the block around the typecheck job name "Type check" / job key "typecheck")
to reflect the current 2vCPU runner (or remove the stale note entirely) so the
comment matches the runner configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 41ddc9c0-d28f-4fe8-b6ec-64d2124a6963
📒 Files selected for processing (7)
.github/workflows/build.yml.github/workflows/cli.yml.github/workflows/commitlint.yml.github/workflows/lint.yml.github/workflows/release.yml.github/workflows/security.yml.github/workflows/test.yml
yannickmonney
force-pushed
the
chore/ci-github-hosted-runners
branch
from
cdb2808 to
46eec01
Compare
yannickmonney
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo is public, so ubuntu-latest is free. Move CI jobs off Blacksmith to cut spend.