fix(web): unbreak header/footer + serve llms; drop de-AT/fr-CH locales#1682
Merged
Conversation
Two bugs introduced by the @tale/webui split (#1680). 1. Header/footer styling was unstyled. The marketing site now imports the shared SiteHeader/SiteFooter shells from @tale/webui, but services/web/app/globals.css still imported @tale/ui/globals.css — so Tailwind's @source directive only scanned packages/ui/src. Utilities used exclusively inside packages/webui/src/layout/ (e.g. lg:grid-cols-[1fr_auto_1fr], lg:grid-cols-[minmax(220px, 1fr)_repeat(3,minmax(0,1fr))], bg-bg-base, text-fg-muted, border-border-base) were never generated. Switching the import to @tale/webui/globals.css picks up its @source for the webui package and matches what services/docs already does. 2. /llms.txt and /llms-full.txt 404'd in dev. The artifact builder wrote into dist/, which only bun server.ts (production) serves. Vite dev serves public/, so dev requests fell through to the SPA index. Mirror the docs pipeline: write into public/, run the builder before vite build/dev, and let vite copy the artifacts into dist/ at build time. Also extends @tale/webui's SiteFooter with a sibling llmsFullTxtUrl / llmsFullTxtLabel slot so the marketing footer can link both files side-by-side. Wires those up in services/web with new translations.
Removes the de-AT and fr-CH locale tracks across every workspace
(@tale/webui, services/{platform,docs,web}, packages/ui parity tests,
tools/plop) and the agent terminology side-files; only de-CH and the
canonical de/fr remain.
Adds the missing de-CH translation tree under /docs and refreshes
related infrastructure: i18n init/locales modules, narrow-bcp47 +
resolve-agent-locale, parity tests, README headers, AGENTS docs, and
the plop service template.
yannickmonney
changed the title
Contributor
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (88)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled change with two independent commits:
1.
fix(web)— unbreak header/footer + serve llms artifactsTwo regressions from the @tale/webui split (#1680), plus a footer polish.
SiteHeader/SiteFootershells from@tale/webui, but services/web/app/globals.css still imported@tale/ui/globals.css. Tailwind v4's@sourcedirective in that sheet only scanspackages/ui/src, so utilities used exclusively inpackages/webui/src/layout/*(e.g.lg:grid-cols-[1fr_auto_1fr],lg:grid-cols-[minmax(220px,1fr)_repeat(3,minmax(0,1fr))],bg-bg-base,text-fg-muted,border-border-base) never got generated. Switched the import to@tale/webui/globals.cssto pick up its@sourcefor the webui package — same patternservices/docsalready uses./llms.txtand/llms-full.txt404'd inbun dev. The artifact builder wrote intodist/, which onlybun server.ts(production) serves. Vite dev servespublic/, so dev requests fell through to the SPA index. Mirrored the docs pipeline: write intopublic/, run the builder beforevite build/vite dev, and let vite copy the artifacts intodist/at build time..gitignoreextended for the new generated paths.@tale/webui'sSiteFooterwith siblingllmsFullTxtUrl/llmsFullTxtLabelprops and wired both/llms.txtand/llms-full.txtinto the marketing footer with newfooter.llmsTxtLabel/footer.llmsFullTxtLabeltranslations (en,de,fr).2.
chore— drop de-AT/fr-CH locales, complete de-CH docs@tale/webui,services/{platform,docs,web},packages/uiparity tests,tools/plop) and the agent terminology side-files. Only de-CH plus the canonicalde/frremain./docsand refreshes related infrastructure: i18n init/locales modules,narrow-bcp47+resolve-agent-locale, parity tests, README headers, AGENTS docs, and the plop service template.Test plan
oxlint --type-awareclean for@tale/weband@tale/webui(commit 1)tsc --noEmitclean for@tale/weband@tale/webui(commit 1)vitest --runpasses for@tale/web(commit 1)oxfmt --checkclean for the touched files (commit 1)vite buildsucceeds; generated CSS contains the previously-missing utilities (grid-cols-[1fr_auto_1fr],minmax(220px,1fr),bg-bg-base,text-fg-muted,border-border-base)curl :3001/llms.txtreturnsContent-Type: text/plain(vite dev) — was returning the SPAtext/htmlbeforebun startserves/llms.txtand/llms-full.txtcorrectly: 200 /text/plainbun run checkagainst the merged base before mergePre-PR checklist
bun run check(format, lint, typecheck, all tests). Skipped per-commit; should run against the bundled diff before merge.services/platform/messages/{en,de,fr}.json— N/A for both commits (de-CH overlay updated under commit 2)./docs/{en,de,fr}/for every user-visible change — N/A (commit 2 adds/docs/de-CH/**overlay).bun run --filter @tale/docs lintandbun run --filter @tale/docs test— should run against the merged diff.README.md,README.de.md,README.fr.md— covered by commit 2.