Skip to content

feat(docs): forward DOCS_SITE_URL through Dockerfile build args#1685

Merged
yannickmonney merged 1 commit into
mainfrom
feat/docs-site-url
May 8, 2026
Merged

feat(docs): forward DOCS_SITE_URL through Dockerfile build args#1685
yannickmonney merged 1 commit into
mainfrom
feat/docs-site-url

Conversation

@yannickmonney

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #1684. prerender.ts and build-llms-artifacts.ts both already read process.env.DOCS_SITE_URL to compose canonical URLs, og:url, sitemap entries, and the absolute URLs in llms.txt / llms-full.txt. But the value wasn't plumbed through the Dockerfile, so every production build silently fell back to the hardcoded https://docs.tale.dev default — the only knob the host had over canonical URLs was editing the source.

Change

  • services/docs/Dockerfile — add ARG DOCS_SITE_URL and ENV DOCS_SITE_URL=... next to the existing DOCS_BASE_URL plumbing.
  • compose.docs.yml — forward DOCS_SITE_URL from the host env to the build args.

The default https://docs.tale.dev keeps the canonical docs.tale.dev deployment unchanged.

Pre-PR checklist

  • Ran bun run check — N/A (Dockerfile + compose only, no JS/TS touched).
  • Updated services/platform/messages/{en,de,fr}.json — N/A.
  • Updated /docs/{en,de,fr}/ — N/A.
  • Ran bun run --filter @tale/docs lint/test — N/A (no source changes).
  • Updated README.md and translations — N/A.

Test plan

  • DOCS_SITE_URL=https://tale.dev/docs DOCS_BASE_URL=/docs/ docker compose -f compose.docs.yml build → built HTML in /dist/index.html should have <link rel="canonical" href="https://tale.dev/docs/" /> and matching og:url.
  • Default build (no env) still produces <link rel="canonical" href="https://docs.tale.dev/" />.

prerender.ts and build-llms-artifacts.ts already read process.env.DOCS_SITE_URL
to build canonical URLs, og:url, sitemap entries, etc. — but it wasn't
plumbed through the Dockerfile, so production builds always fell back
to the 'https://docs.tale.dev' default.

Mirror the existing DOCS_BASE_URL pattern: declare ARG + ENV in the
builder stage, forward via compose.docs.yml build args. Default keeps
the docs.tale.dev value for the canonical deployment.
@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@yannickmonney has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 35 minutes and 54 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: eb305e73-2a80-45f7-b420-e4723d6afb47

📥 Commits

Reviewing files that changed from the base of the PR and between 9d9ec26 and 9535b1f.

📒 Files selected for processing (2)
  • compose.docs.yml
  • services/docs/Dockerfile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/docs-site-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yannickmonney yannickmonney merged commit e70fe7b into main May 8, 2026
12 checks passed
@yannickmonney yannickmonney deleted the feat/docs-site-url branch May 8, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant