Skip to content

fix(platform): unwrap integration list envelope so issue desk shows issues#2175

Merged
larryro merged 1 commit into
mainfrom
fix/issue-desk-empty-list-envelope
Jun 27, 2026
Merged

fix(platform): unwrap integration list envelope so issue desk shows issues#2175
larryro merged 1 commit into
mainfrom
fix/issue-desk-empty-list-envelope

Conversation

@larryro

@larryro larryro commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

What

The issue desk rendered no issues even when untracked GitHub issues existed.

executeIntegration returns an envelope whose connector payload — the issues array plus the upstream "is there a next page" hint — lives under .result:

{ name, operation, result: { data, pagination, ... }, ... }

listUntrackedGitHubIssues read res.data / res.pagination from the top level, which always resolved to undefined → an empty page with no next page → the filtered list collapsed to nothing.

Fix

Extract a shared readIntegrationListPage helper that:

  • unwraps .result first (mirroring the client's parsePage),
  • tolerates an already-flat { data, pagination } payload for forward compatibility (a future connector that returns the payload directly still works),
  • degrades to an empty, terminal page on a malformed/null result.

listUntrackedGitHubIssues now delegates to it instead of reading the top level.

Tests

New integration_list_page.test.ts covers the nested envelope, the hasNext signal, the regression shape (top-level data must be ignored), the forward-compatible flat shape, and malformed input. All 5 pass.

…ssues

`executeIntegration` returns an envelope whose connector payload (the
issues array + upstream page hint) lives under `.result`. The untracked-
issues action read `res.data` / `res.pagination` from the top level, which
always yielded `undefined` — an empty page with no next page — collapsing
the issue desk to nothing.

Extract a shared `readIntegrationListPage` helper that unwraps `.result`
first (mirroring the client's `parsePage`), tolerates an already-flat
payload for forward compatibility, and degrades to an empty terminal page
on a malformed result. Covered by unit tests.
@larryro larryro merged commit ea1cfea into main Jun 27, 2026
68 of 69 checks passed
@larryro larryro deleted the fix/issue-desk-empty-list-envelope branch June 27, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant