Rc/8.1.0 - #225
Conversation
tompsota
left a comment
There was a problem hiding this comment.
@martinzigrai , the ios hierarchy looks like this: ios/freerasp/Sources/freerasp/..., i.e there is extra freerasp subfolder. Can you remove it?
tompsota
left a comment
There was a problem hiding this comment.
When you run example app, there are some modified files. Can you commit them?
Add a CI job that builds the example app with SPMRight now nothing in CI exercises the Swift Package Manager path that this PR adds. Two things need to happen:
build-ios-spm:
runs-on: macos-latest
needs: test
steps:
- name: 📚 Git Checkout
uses: actions/checkout@v6
- name: 🐦 Setup Flutter
uses: subosito/flutter-action@v2
with:
channel: stable
flutter-version: 3.41.0 # FlutterFramework SwiftPM package requires 3.41.0+
cache: true
- name: 📦 Enable Swift Package Manager
run: flutter config --enable-swift-package-manager
- name: 🍎 Build iOS app (SPM)
working-directory: example
run: flutter build ios --release --no-codesignNote that the workflow currently pins A cheap extra safety net worth considering in the same job: download the URL from the |
Document the Flutter 3.41.0 minimum for the SPM pathThe changelog entry says "Swift Package Manager (SPM) support for iOS" without qualification, and neither the README nor the docs mention a version requirement. In practice SPM support here requires Flutter 3.41.0 or newer, and consumers on older SDKs who enable the feature flag will hit a build failure with no indication of why. Why 3.41.0 specifically. dependencies: [
.package(name: "FlutterFramework", path: "../FlutterFramework")
]This is a filesystem path, not a registry lookup, so if nothing exists at that location SPM fails during resolution with "the package at ... cannot be accessed" before anything compiles. What's on disk depends on the Flutter version:
(Introduced by flutter/flutter#181578, "Generate Flutter framework swift package", first released in 3.41.0.) Suggested handling. I'd leave the
Worth noting the blast radius is limited — SPM is still opt-in behind the feature flag even in 3.41, so only users who explicitly enabled it are exposed. But those are exactly the users this feature was built for, and the failure they'd get is an opaque SPM resolution error that gives no hint that their Flutter version is the problem. |
resolves #203
dSYMs.zip