add --crypto flag to currencies and rename Type to PriceType#3
Merged
Conversation
currencies --crypto now calls /v2/currencies/crypto and maps the code/name wire shape to Currency (fiat uses id/name/min_size). Price.Type renamed to PriceType with json tag price_type to match the spec and avoid confusion with Go's built-in type keyword.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currencies --cryptonow fetches/v2/currencies/cryptoand maps itscode/namewire shape into the sharedCurrencytype (fiat usesid/name/min_size)Price.Typerenamed toPrice.PriceTypewith JSON tagprice_typeto match the spec and avoid shadowing Go's reserved wordTest plan
go build ./...passesgo test -count=1 ./...— 14 tests passcoinbase spot BTC-USD— returnsprice_type: spotcoinbase buy ETH-USD— returnsprice_type: buycoinbase rates BTC --to USD,EUR,GBP,JPY— 4 filtered rowscoinbase currencies— first row: AED, UAE Dirhamcoinbase currencies --crypto— first row: BTC, Bitcoin