Implement lookup op with lat/lon parsing and bogon handling#1
Merged
Conversation
- Single lookup op (optional IP arg; omit to look up your own IP) - IPInfo struct gains Lat/Lon split from the loc field - Bogon IPs (private ranges) return what the API provides, no error - Wire struct intermediary decouples raw JSON from output shape - Tests cover lat/lon parsing, bogon response, retry on 429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lookupop with optional IP arg; omit the arg to look up your own IP via/jsonIPInfostruct gainsLatandLonfields split from thelocfield returned by the API{"ip":"...","bogon":true}with no geo data — the client now handles this gracefully with no error, emitting what the API provideswireintermediary struct decouples raw JSON (withlocandbogon) from the clean output shapeTest plan
go build ./...passesgo test ./...passes (6 tests: UserAgent, LookupIP, Me, Bogon, Batch, Retry)./bin/ipinfo lookup 8.8.8.8— Mountain View, lat/lon split correctly./bin/ipinfo lookup 1.1.1.1— Brisbane, lat/lon split correctly./bin/ipinfo lookup(no arg) — own IP lookup via /json