Remove the unused @types/jsdom devDependency and a stale test TODO - #3608
Merged
Conversation
Nothing imports jsdom's types: the suite only sets Jest's `testEnvironment: 'jsdom'`, a string that needs no types, and jest-environment-jsdom carries its own @types/jsdom transitively. The direct dependency was added in a bulk tooling refactor without a traced use. Both knip and depcheck flag it; check:types, lint and the full test gate pass without it.
The note marked an aspiration to style child element fills, added in 2019 with no linked issue and never acted on. No fill-styling code or assertion ever followed it, so it is dead intent, not a pending task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dead-code pass across the repo. Two removals survived verification; everything else checked came up clean.
@types/jsdomwas an unused devDependency. Nothing imports jsdom's types: the suite only sets Jest'stestEnvironment: 'jsdom', a string that needs no types, andjest-environment-jsdomcarries its own@types/jsdomtransitively. Both knip and depcheck flag it. Removing it also prunes the now-orphaned top-levelundici-typesfrom the lockfile;@types/nodekeeps its own nested copy.// TODO: Style child element fills.intest/browser.spec.tsx, added in 2019 with no linked issue and never acted on.Verified with
check:types,lint,check:formatandtest:srcafter the removals, then the fullnpm testgate (build, size, cjs/es/dist, and the whole React matrix through 19.1) green.