fix(campaign): reject duplicate candidate surfaces - #571
Merged
Conversation
tangletools
approved these changes
Aug 11, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved drewstone PR — 968d0ece
This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: drewstone_author · 2026-08-11T00:30:12Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runOptimization previously dispatched repeated surfaceHash values as separate candidate records. That admitted duplicate population rows and made a claimed broad population non-unique. This change validates every proposed surface against the baseline, earlier generations, and the current proposal before candidate dispatch; rejects duplicates with the exact surface hash and generation; keeps repeated measurements explicit through reps; adds same-generation and cross-generation offline tests proving duplicate candidates do not dispatch; updates proposer guidance and existing no-op fixtures to use distinct candidates. Proof on origin/main 0624e26: focused run-optimization test 20 passed; pnpm test 5386 passed, 3 skipped across 389 files (2 skipped); lint, typecheck, example/script typechecks, build, verify:package, and staged gitleaks all pass. No model or paid calls.