feat(pages): make evidence and invalidation integrity first-class - #147
Merged
Conversation
tangletools
previously approved these changes
Aug 17, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved drewstone PR — fbad21b2
This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
This approval is provisional. It rests on the audit running. If the audit cannot run — for example the CLI bridge rejects it — this approval is dismissed rather than left standing, so an unrun check never reads as a passing one.
tangletools · auto-approval · reason: drewstone_author · 2026-08-17T01:57:46Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The package can grade claim evidence and can lint a knowledge index, but the two surfaces were disconnected. A page could claim rung 4 or 5 while carrying no executable check, no expected value, no evidence path, or an author-machine absolute path and still pass index lint.
The package also had no page-level representation for two distinct facts a research store needs:
The claim ledger's symmetric
contestedrelation is correct for unresolved source disagreement. It is not correct for an executable page that its own check contradicted: that invalidation is asymmetric and the page is dead.Change
KnowledgePage.contradictspage-id references.KnowledgePageInvalidationwhose only verdict iscontradictedand which records timestamp, reason, evidence path, grader, and metadata.KnowledgePageSchemaandKnowledgeIndexSchematransitively.lintKnowledgeIndexto report:assertGradeableEvidenceboundary;Evidence lint reuses the package's one refusal vocabulary rather than restating what is gradeable. Invalid frontmatter remains visible in the raw page and becomes a lint error instead of disappearing silently.
Tests
The suite covers gradeable portable evidence, self-grades, absolute paths, valid and broken contradiction edges, strict invalidation semantics, and loading string/array pointers plus typed invalidation metadata from disk.
This closes the page-evidence and asymmetric-invalidation gaps identified by Discovery's adoption audit without weakening the separate claim-ledger semantics.