Skip to content

fix(bridge): finish active turn after accepted result - #829

Merged
drewstone merged 1 commit into
mainfrom
fix/bridge-stop-after-turn-20260813
Aug 13, 2026
Merged

fix(bridge): finish active turn after accepted result#829
drewstone merged 1 commit into
mainfrom
fix/bridge-stop-after-turn-20260813

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

Problem

An accepted coordination result aborted the active cli-bridge request. The bridge then lost its served model and terminal profile materialization, so strict dispatch correctly rejected the receipt as unknown.

Change

Pass Runtime completion as a private bridge control signal. The active SSE turn drains through its provider usage, served model, terminal profile materialization, and DONE receipt. The next turn checks the completion signal before dispatch. Scope cancellation still aborts the active request.

Proof

  • 94/94 focused bridge and moving-alias loop tests pass.
  • Active completion regression asserts one POST, known provider evidence, known terminal materialization, and direct artifact.
  • Abort-before-DONE regression asserts unknown provider identity and pending materialization.
  • typecheck, examples typecheck, Biome lint, and diff check pass.

Closes the regression in merged PR 828. Release 0.133.8 remains held until this fix is green in CI.

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved drewstone PR — d0daa350

This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.

This approval is provisional. It rests on the audit running. If the audit cannot run — for example the CLI bridge rejects it — this approval is dismissed rather than left standing, so an unrun check never reads as a passing one.

tangletools · auto-approval · reason: drewstone_author · 2026-08-13T21:52:05Z

@drewstone
drewstone merged commit 24549c4 into main Aug 13, 2026
4 checks passed
@drewstone
drewstone deleted the fix/bridge-stop-after-turn-20260813 branch August 13, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants