fix(pi): preserve terminal and token accounting - #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pi sessions ending with
stopReason: errorwere reported as successful, while reasoning and cache token dimensions were discarded.The live GLM-5.2 run exposed both failures: two workers ended with
Stream ended without finish_reason, yet trace analysis called both successful and omitted 30,397 root reasoning tokens plus 300,736 cache-read tokens across the root and active worker.Change
Proof
pnpm test: 373/373 passedpnpm typecheck: passedpnpm build: passed