feat(otlp): inbound OTLP — validate, analyze --otlp, loop/steering analyses, faithful round-trip - #72
Merged
Merged
Conversation
…alyses, faithful round-trip The analysis pipeline was OTLP-native with no inbound path: 18 adapters read proprietary session stores and --otlp was an output flag. Any system that already emits OpenInference spans still needed an adapter. Now: - traces validate <file|dir> renders the contract's conformance report — the verdict, every finding, and the capability table naming what can be analysed and what each gap costs. Exit 1 only when the input is not a trace. - traces analyze --otlp feeds existing OTLP-JSONL straight into the pipeline. Directories ingest every OTLP file and skip raw event logs instead of counting their lines as errors. Reports gate every table on its capability — numbers whose inputs are incomplete are marked, never printed bare. - loop-convergence and steering-chain are implemented, not advertised: per-loop round-over-round score series, and the steered_by link chain showing which verdict caused which retry. - The round trip is faithful: re-exporting preserves span kinds, status, producer timestamps, unknown kinds, and the finding-code set — a re-validated artifact carries its source's verdict. The one impossible case (a span with no trace id must be minted one or the artifact is unreadable) is declared on the fixture and stated in the report, not silently absorbed. - The contract build is stamped on every exported artifact and verified against the lockfile-pinned tarball byte-for-byte — the digest leg fails on any tree that is not the locked one. - Adapters are demoted in the docs to the legacy edge for formats we do not control; the way to integrate a new system is: emit the contract, point --otlp at it. Suite: 41 files / 538 tests. Source-text guard added after two raw NUL bytes were found hiding files from grep — one already shipped on main.
…luting a JSON stream CI failed with 'Unexpected token s, "source tex"... is not valid JSON': the guard's success line printed to stdout, and a packaging step that parses its child's stdout as JSON swallowed it. Diagnostics belong on stderr; success is otherwise silent.
…ds on a cold runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
traces becomes consumable by any system that emits the span contract, with no adapter:
traces validate <file|dir>— the conformance report: verdict (error= not a trace → exit 1;warn= analysable but degraded), every finding, and the capability table naming what each gap costs.traces analyze --otlp <file|dir>— OTLP-JSONL straight into the existing pipeline (reused, not forked). Directory ingest skips non-OTLP files instead of counting their lines as errors.loop-convergence+steering-chainimplemented — the two analyses this project exists for: round-over-round score series per loop, and thesteered_bylink chain showing which verdict caused which retry. Previously advertised with no implementation (audit finding).Verification
convert --otlp(write) is now--otlp-out;--otlpmeans read. Deprecation shim + changeset included.