This repository was archived by the owner on Apr 7, 2022. It is now read-only.
Check mariadbclient version #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mariadb client package includes its own version number. Let's return that as well. We guard that in an #if block so that future package versions without that define still create a valid test. We also upgrade from the obsolete AC_TRY_LINK to AC_LINK_IFELSE. The mariadb client version is then returned in MARIADBCLIENT_VERSION.
This now has a fixed alignement ignoring the database type.
And also disambiguate DB_VERSION to DB_SERVER_VERSION.
t-b
force-pushed
the
check-mariadb-version
branch
from
5e3bd53 to
828c055
Compare
Reports [1] indicate that versions 2 of the mariadb client package trigger DatabaseDS crashes when the database connection timeout is reached. In order to warn users about potential issues we now about a warning message in this case. [1]: tango-controls#61 The output on a stock debian stretch system looks like Configuration (tango): Source code location: . Version: 9.3.4-rc1 Compiler: gcc,g++ OMNIORB PATH: /usr/local OMNIORB VERSION: ZMQ PATH: /usr ZMQ VERSION: 4.2.1 JAVA PATH: /usr/bin/java JAVA VERSION: 1.8.0_131 Database MARIADB CLIENT LIB: -lmariadb CLIENT VERSION: 2.3.2 (Warning! potentially buggy version) VERSION: 10.1.41-MariaDB CONNECTION: OK build: libraries: yes java application: yes access control server: yes database server: yes database schema create: yes notice "Warning .." message. On debian unstable it looks better Configuration (tango): Source code location: . Version: 9.3.4-rc2 Compiler: gcc,g++ OMNIORB PATH: /usr OMNIORB VERSION: "4.2.2" ZMQ PATH: /usr ZMQ VERSION: 4.3.2 JAVA PATH: /usr/bin/java JAVA VERSION: 1.8.0_242-ea Database MARIADB CLIENT LIB: -lmariadb CLIENT VERSION: 3.1.6 VERSION: 10.3.21-MariaDB CONNECTION: OK build: libraries: yes java application: yes access control server: yes database server: yes database schema create: yes
t-b
force-pushed
the
check-mariadb-version
branch
from
828c055 to
0a03661
Compare
Member
Contributor
Author
|
@bourtemb Let's do that in the release notes. |
Contributor
Author
|
@bourtemb Good to merge? |
bourtemb
approved these changes
Mar 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #61
Close #68
@mliszcz @bourtemb Ready for review. Please note that I'm a total automake novice.
The interesting commits are 95b0a6d and 0a03661.