This repository was archived by the owner on Apr 7, 2022. It is now read-only.
Bugfix/avoid checking database server process #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of mariadb database server we can't just check that the mysqld process is running. Now we could check for mariadb as well. Or just rely on the DatabaseDS to complain if no database is running. We do the latter.
bourtemb
approved these changes
Aug 13, 2020
Member
bourtemb
left a comment
bourtemb
left a comment
There was a problem hiding this comment.
Removal of the mysql DB process checks looks good to me.
I think we still have the risk to accidentally kill a process named DataBaseSupervisor for instance when tango_wca stop is invoked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #84.