Default PCH to on

[t-b]

Close #567.

[mliszcz]

Looks good to me.

[bourtemb]

OK then! Thanks!
Looks good to me!

[bourtemb]

This PR disabled SONAR_SCANNER and COVERALLS which used to be ON when building on Debian 8.
I don't remember whether we discussed this point or if we missed that point when reviewing this PR?

[t-b]

@bourtemb Good point. I think we want

OS_TYPE=debian10 USE_PCH=OFF RUN_TESTS=OFF SONAR_SCANNER=ON

or?

[bourtemb]

@bourtemb Good point. I think we want

OS_TYPE=debian10 USE_PCH=OFF RUN_TESTS=OFF SONAR_SCANNER=ON

or?

and COVERALLS=ON too

[t-b]

@bourtemb Yes, but let's go with readding it to debian8 as @mliszcz did in #568.

[mliszcz]

Hi @t-b and @bourtemb

Do you have any experience with sonar and coveralls setup? Below are logs from Debian 8 job:

https://travis-ci.org/tango-controls/cppTango/jobs/640430653?utm_medium=notification&utm_source=github_status

Coveralls:

[  0%] Built target coveralls_generate
make -f CMakeFiles/coveralls_upload.dir/build.make CMakeFiles/coveralls_upload.dir/depend
make[3]: Entering directory '/home/tango/src/build'
cd /home/tango/src/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tango/src /home/tango/src /home/tango/src/build /home/tango/src/build /home/tango/src/build/CMakeFiles/coveralls_upload.dir/DependInfo.cmake --color=
Scanning dependencies of target coveralls_upload
make[3]: Leaving directory '/home/tango/src/build'
make -f CMakeFiles/coveralls_upload.dir/build.make CMakeFiles/coveralls_upload.dir/build
make[3]: Entering directory '/home/tango/src/build'
/usr/bin/cmake -E cmake_progress_report /home/tango/src/build/CMakeFiles 34
[100%] Uploading coveralls output...
/usr/bin/curl -S -F json_file=@/home/tango/src/build/coveralls.json https://coveralls.io/api/v1/jobs
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 15 1031k    0     0   15  160k      0  1260k --:--:-- --:--:-- --:--:-- 1261k
100 1031k    0    72  100 1031k     54   774k  0:00:01  0:00:01 --:--:--  773k
100 1031k    0    72  100 1031k     54   774k  0:00:01  0:00:01 --:--:--  773k
{"message":"Couldn't find a repository matching this job.","error":true}make[3]: Leaving directory '/home/tango/src/build'

Coverage is not visible: https://coveralls.io/github/tango-controls/cppTango

Sonar:

�[0K$ test ${SONAR_SCANNER} = "ON" && .travis/sonar.sh
Using SONAR_PROPERTIES=-Dsonar.pullrequest.base=tango-9-lts -Dsonar.pullrequest.branch=reset-database-and-ds-for-each-test -Dsonar.pullrequest.key=640
.travis/sonar.sh: line 11: sonar-scanner: command not found

I'm trying to find some hints in commit history but with no luck so far.

[t-b]

@mliszcz Maybe coverage is only computed for tango-9-lts? In any case I would tackle that in a different PR.

[mliszcz]

@t-b I'v just opened an issue (#661) for fixing Sonar and Coveralls.